Assign partition again if registerShuffleServers failed #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
============================================
+ Coverage 56.52% 56.56% +0.03%
- Complexity 1183 1191 +8
============================================
Files 149 150 +1
Lines 8019 8048 +29
Branches 767 771 +4
============================================
+ Hits 4533 4552 +19
- Misses 3242 3249 +7
- Partials 244 247 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Member
Author
I don't know how to write this ut, it is difficult to stop shuffle server when |
Contributor
|
You can follow the steps:
|
jerqi
reviewed
Aug 1, 2022
client-mr/src/main/java/org/apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java
Show resolved
Hide resolved
jerqi
reviewed
Aug 1, 2022
integration-test/common/src/test/java/org/apache/uniffle/test/IntegrationTestBase.java
Outdated
Show resolved
Hide resolved
# Conflicts: # client-mr/src/main/java/org/apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java # client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java # client-spark/spark2/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java # client-spark/spark3/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java
jerqi
approved these changes
Aug 2, 2022
Contributor
jerqi
left a comment
jerqi
left a comment
There was a problem hiding this comment.
LGTM, great work! Thanks for your contribution! @xianjingfeng
This was referenced Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Assign partition again if registerShuffleServers failed
Why are the changes needed?
If registerShuffleServers failed, task will fail and then application will failed
Does this PR introduce any user-facing change?
No
How was this patch tested?
Already added