-
Notifications
You must be signed in to change notification settings - Fork 170
Assign partition again if registerShuffleServers failed #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8f3ea56
Assign partition again if registerShuffleServers failed
xianjingfeng 5d87435
modify retry interval
xianjingfeng 95e646f
fix checkstyle issue
xianjingfeng ac9c161
support mr client
xianjingfeng b3d3199
add ut
xianjingfeng 0c411af
add configuration option for retry interval and retry times
xianjingfeng 78c4a3c
Merge branch 'master' into issue_107
xianjingfeng ba0989e
fix checkstyle issue
xianjingfeng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81 changes: 81 additions & 0 deletions
81
common/src/main/java/org/apache/uniffle/common/util/RetryUtils.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.uniffle.common.util; | ||
|
|
||
| import java.util.Set; | ||
|
|
||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class RetryUtils { | ||
| private static final Logger LOG = LoggerFactory.getLogger(RetryUtils.class); | ||
|
|
||
| public static <T> T retry(RetryCmd<T> cmd, long intervalMs, int retryTimes) throws Throwable { | ||
| return retry(cmd, null, intervalMs, retryTimes, null); | ||
| } | ||
|
|
||
| /** | ||
| * @param cmd command to execute | ||
| * @param callBack the callback command executed when the attempt of command fail | ||
| * @param intervalMs retry interval | ||
| * @param retryTimes retry times | ||
| * @param exceptionClasses exception classes which need to be retry, null for all. | ||
| * @param <T> return type | ||
| * @return | ||
| * @throws Throwable | ||
| */ | ||
| public static <T> T retry(RetryCmd<T> cmd, RetryCallBack callBack, long intervalMs, | ||
| int retryTimes, Set<Class> exceptionClasses) throws Throwable { | ||
| int retry = 0; | ||
| while (true) { | ||
| try { | ||
| T ret = cmd.execute(); | ||
| return ret; | ||
| } catch (Throwable t) { | ||
| retry++; | ||
| if ((exceptionClasses != null && !isInstanceOf(exceptionClasses, t)) || retry >= retryTimes) { | ||
| throw t; | ||
| } else { | ||
| LOG.info("Retry due to Throwable, " + t.getClass().getName() + " " + t.getMessage()); | ||
| LOG.info("Waiting " + intervalMs + " milliseconds before next connection attempt."); | ||
| Thread.sleep(intervalMs); | ||
| if (callBack != null) { | ||
| callBack.execute(); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private static boolean isInstanceOf(Set<Class> classes, Throwable t) { | ||
| for (Class c : classes) { | ||
| if (c.isInstance(t)) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| public interface RetryCmd<T> { | ||
| T execute() throws Throwable; | ||
| } | ||
|
|
||
| public interface RetryCallBack { | ||
| void execute() throws Throwable; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.