Skip to content

Conversation

@zuston
Copy link
Member

@zuston zuston commented Jul 4, 2022

What changes were proposed in this pull request?

  1. Correct the config description
  2. Fix typo

Why are the changes needed?

Typo

Does this PR introduce any user-facing change?

No

How was this patch tested?

No need.

@zuston
Copy link
Member Author

zuston commented Jul 4, 2022

minor fix @jerqi

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2022

Codecov Report

Merging #19 (4fc34db) into master (eb15611) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master      #19      +/-   ##
============================================
- Coverage     56.27%   56.22%   -0.05%     
  Complexity     1168     1168              
============================================
  Files           152      152              
  Lines          8397     8397              
  Branches        812      812              
============================================
- Hits           4725     4721       -4     
- Misses         3408     3412       +4     
  Partials        264      264              
Impacted Files Coverage Δ
...rg/apache/uniffle/coordinator/CoordinatorConf.java 96.11% <100.00%> (ø)
.../java/org/apache/uniffle/server/ShuffleServer.java 69.02% <0.00%> (-3.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb15611...4fc34db. Read the comment docs.

Copy link
Member

@kaijchen kaijchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerqi jerqi merged commit 2fc3c26 into apache:master Jul 4, 2022
colinmjj pushed a commit to colinmjj/incubator-uniffle that referenced this pull request Jul 5, 2022
### What changes were proposed in this pull request?
1. Correct the config description
2. Fix typo

### Why are the changes needed?
Typo

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
No need.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants