Skip to content

Correct the config description and fix typo #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryqi merged 1 commit into from
Jul 4, 2022
Merged

Correct the config description and fix typo #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorConf.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public class CoordinatorConf extends RssBaseConf {
.intType()
.checkValue(ConfigUtils.positiveIntegerValidator2, "load checker serverNum threshold must be positive")
.noDefaultValue()
.withDescription("Accessed candidates file path");
.withDescription("The minimal required number of healthy shuffle servers when being accessed by client");
public static final ConfigOption<Boolean> COORDINATOR_DYNAMIC_CLIENT_CONF_ENABLED = ConfigOptions
.key("rss.coordinator.dynamicClientConf.enabled")
.booleanType()
Expand All @@ -105,7 +105,7 @@ public class CoordinatorConf extends RssBaseConf {
.key("rss.coordinator.remote.storage.path")
.stringType()
.noDefaultValue()
.withDescription("all supported remote paths for RSS cluster, seperated by ','");
.withDescription("all supported remote paths for RSS cluster, separated by ','");
public static final ConfigOption<Integer> COORDINATOR_DYNAMIC_CLIENT_CONF_UPDATE_INTERVAL_SEC = ConfigOptions
.key("rss.coordinator.dynamicClientConf.updateIntervalSec")
.intType()
Expand All @@ -116,7 +116,7 @@ public class CoordinatorConf extends RssBaseConf {
.key("rss.coordinator.remote.storage.cluster.conf")
.stringType()
.noDefaultValue()
.withDescription("Remote Storage Cluster related conf with format $clusterId,$key=$value, sperated by ';'");
.withDescription("Remote Storage Cluster related conf with format $clusterId,$key=$value, separated by ';'");


public CoordinatorConf() {
Expand Down