Change total lines badge to tokei.rs in README#221
Closed
kaijchen wants to merge 1 commit intoapache:masterfrom
Closed
Change total lines badge to tokei.rs in README#221kaijchen wants to merge 1 commit intoapache:masterfrom
kaijchen wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
Seems #222 is more stable. |
kaijchen
changed the title
Member
Author
|
Closing this due to #222. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change "total lines" badge url to tokei.rs
And use empty alt message to display nothing on failure.
See https://github.com/XAMPPRocky/tokei#badges
Why are the changes needed?
Current badge sometimes show "total lines: invalid".
Does this PR introduce any user-facing change?
No.
How was this patch tested?
https://github.com/kaijchen/incubator-uniffle/tree/tokei#apache-uniffle-incubating