Change total lines badge url to sloc.xyz in README #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaijchen
changed the title
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
=========================================
Coverage 59.13% 59.13%
Complexity 1327 1327
=========================================
Files 160 160
Lines 8727 8727
Branches 817 817
=========================================
Hits 5161 5161
Misses 3301 3301
Partials 265 265 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
This link seems much faster. LGTM, pending on CI. |
jerryshao
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change "total lines" badge url to sloc.xyz
And use empty alt message to display nothing on failure.
Why are the changes needed?
Current badge sometimes show "total lines: invalid".
Does this PR introduce any user-facing change?
No.
How was this patch tested?
https://github.com/kaijchen/incubator-uniffle/tree/sloc#apache-uniffle-incubating