[#755] refactor: Add the method of creating thread pool #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallzhongfeng
changed the title
Codecov Report
@@ Coverage Diff @@
## master #767 +/- ##
============================================
+ Coverage 60.63% 63.08% +2.44%
- Complexity 1893 1954 +61
============================================
Files 238 230 -8
Lines 13000 11336 -1664
Branches 1090 1118 +28
============================================
- Hits 7883 7151 -732
+ Misses 4679 3789 -890
+ Partials 438 396 -42
... and 52 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jerqi
changed the title
Contributor
Author
|
Thanks ! @jerqi Merged to master. |
xianjingfeng
pushed a commit
to xianjingfeng/uniffle
that referenced
this pull request
Apr 5, 2023
…#767) <!-- 1. Title: [#<issue>] <type>(<scope>): <subject> Examples: - "[apache#123] feat(operator): support xxx" - "[apache#233] fix: check null before access result in xxx" - "[MINOR] refactor: fix typo in variable name" - "[MINOR] docs: fix typo in README" - "[apache#255] test: fix flaky test NameOfTheTest" Reference: https://www.conventionalcommits.org/en/v1.0.0/ 2. Contributor guidelines: https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md 3. If the PR is unfinished, please mark this PR as draft. --> ### What changes were proposed in this pull request? Four util methods for creating thread pools have been added. ### Why are the changes needed? Fix: apache#755 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Origin uts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Four util methods for creating thread pools have been added.
Why are the changes needed?
Fix: #755
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Origin uts.