[TYPO] Replace Chinese colon by ASCII colon #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
============================================
- Coverage 59.16% 59.13% -0.03%
+ Complexity 1340 1339 -1
============================================
Files 163 163
Lines 8810 8810
Branches 833 833
============================================
- Hits 5212 5210 -2
- Misses 3332 3333 +1
- Partials 266 267 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
@zuston Kerberos test seems flaky. |
Member
Yes. This test makes me confused, I will take a look |
zuston
approved these changes
Oct 10, 2022
Member
|
Merged. Thanks @kaijchen |
Member
Author
|
Thanks @zuston for merge this. |
Contributor
|
It would be better to cherry-pick this to 0.6 branch and kick off a new RC release. CC\ @jerqi |
Contributor
Ok, I will cherry-pick this pr. |
jerqi
pushed a commit
that referenced
this pull request
Oct 10, 2022
What changes were proposed in this pull request? Replace ： by : . Does this PR introduce any user-facing change? No. How was this patch tested? No need.
smallzhongfeng
added a commit
that referenced
this pull request
Mar 28, 2023
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
Four util methods for creating thread pools have been added.
### Why are the changes needed?
Fix: #755
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Origin uts.
xianjingfeng
pushed a commit
to xianjingfeng/uniffle
that referenced
this pull request
Apr 5, 2023
…#767) <!-- 1. Title: [#<issue>] <type>(<scope>): <subject> Examples: - "[apache#123] feat(operator): support xxx" - "[apache#233] fix: check null before access result in xxx" - "[MINOR] refactor: fix typo in variable name" - "[MINOR] docs: fix typo in README" - "[apache#255] test: fix flaky test NameOfTheTest" Reference: https://www.conventionalcommits.org/en/v1.0.0/ 2. Contributor guidelines: https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md 3. If the PR is unfinished, please mark this PR as draft. --> ### What changes were proposed in this pull request? Four util methods for creating thread pools have been added. ### Why are the changes needed? Fix: apache#755 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Origin uts.
smallzhongfeng
added a commit
that referenced
this pull request
Apr 17, 2023
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
Add `tag` as label in the metrics.
So that we can separate the metrics in Grafana.
### Why are the changes needed?
Fix: #778
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
fix uts.
maobaolong
added a commit
that referenced
this pull request
Jan 7, 2025
… shuffle (#2132) <!-- 1. Title: [#<issue>] <type>(<scope>): <subject> Examples: - "[#123] feat(operator): support xxx" - "[#233] fix: check null before access result in xxx" - "[MINOR] refactor: fix typo in variable name" - "[MINOR] docs: fix typo in README" - "[#255] test: fix flaky test NameOfTheTest" Reference: https://www.conventionalcommits.org/en/v1.0.0/ 2. Contributor guidelines: https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md 3. If the PR is unfinished, please mark this PR as draft. --> ### What changes were proposed in this pull request? Server send heartbeat to coordinator while receive unregister shuffle request. ### Why are the changes needed? Without this PR, server could not heartbeat the updated app info after unregister this app, so the coordinator and dashboard could display the outdate information. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Tested by a tiny spark job executed by spark-shell - shell command line ```shell bin/spark-shell --master spark://localhost:7077 --deploy-mode client --conf spark.rss.coordinator.quorum=localhost:19999 --conf spark.shuffle.manager=org.apache.spark.shuffle.RssShuffleManager --conf spark.rss.storage.type=LOCALFILE --conf spark.serializer=org.apache.spark.serializer.KryoSerializer --conf spark.rss.test.mode.enable=true --conf spark.rss.client.type=GRPC_NETTY --conf spark.default.parallelism=16 -i test.scala ``` - test.scala ```scala val data = sc.parallelize(Seq(("A", 1), ("B", 2), ("C", 3), ("A", 4), ("B", 5), ("A", 6), ("A", 7),("A", 7), ("A", 7), ("A", 7), ("A", 7), ("A", 7), ("A", 7), ("A", 7), ("A", 7), ("A", 7), ("A", 7), ("A", 7), ("A", 7))); val result = data.reduceByKey(_ + _); result.collect().foreach(println); System.exit(0); ``` <img width="2540" alt="image" src="https://github.com/user-attachments/assets/bbd7c534-9fea-4e86-ba5e-84dff3d9c98c">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace
：by:.Does this PR introduce any user-facing change?
No.
How was this patch tested?
No need.