-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-2008] Hide the column if all of its values are 'n/a' in the… #148
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #148 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 1 1
Lines 30 30
=======================================
Hits 20 20
Misses 7 7
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Thanks to @stu01509 for the suggestion, I have updated the code accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
all comments from @stu01509 were handled
… table.
What is this PR for?
remove anything that resolves to "n/a" from the list as that is just noise.
What type of PR is it?
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
before-
after-
Display the column only if the content in all of the cells is not 'n/a'.
The following picture adds the rank name 'rank01' to db.json to demonstrate that it works correctly, which isn't included in this commit.
Questions: