Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2008] Hide the column if all of its values are 'n/a' in the… #148

Closed
wants to merge 11 commits into from

Conversation

wusamzong
Copy link
Contributor

… table.

What is this PR for?

remove anything that resolves to "n/a" from the list as that is just noise.

What type of PR is it?

  • - Improvement

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

before-
Screenshot 2023-11-17 at 11 47 44 AM

after-
Display the column only if the content in all of the cells is not 'n/a'.
The following picture adds the rank name 'rank01' to db.json to demonstrate that it works correctly, which isn't included in this commit.
Screenshot 2023-11-17 at 11 47 02 AM

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@wusamzong wusamzong self-assigned this Nov 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a51966) 66.66% compared to head (bffa39c) 66.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           1        1           
  Lines          30       30           
=======================================
  Hits           20       20           
  Misses          7        7           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wusamzong
Copy link
Contributor Author

Thanks to @stu01509 for the suggestion, I have updated the code accordingly.

Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
all comments from @stu01509 were handled

@wilfred-s wilfred-s closed this in 9bbe0dd Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants