Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-1362] Filtering node list on UI based on node selector #153

Closed
wants to merge 6 commits into from

Conversation

wusamzong
Copy link
Contributor

What is this PR for?

This pull request builds upon YuniKorn Web-PR#148. In response to YUNIKOKORN-1362, it is essential to expose node labels in the web UI. The improvements in this pull request include:

  1. The attributes are exposed in the node table
  2. A filter input has been introduced
  3. The filter results are highlighted
  4. Two nodes have been explicitly added to db.json for testing and validating the filter functionality.

What type of PR is it?

  • - Improvement

What is the Jira issue?

How should this be tested?

yarn start:srv
yarn start:host

Screenshots (if appropriate)

image

Detail mode which will expose attribute
image

The filter results are highlighted
image

@wusamzong wusamzong self-assigned this Nov 28, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e0693d7) 66.66% compared to head (9d55987) 66.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #153   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           1        1           
  Lines          30       30           
=======================================
  Hits           20       20           
  Misses          7        7           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wusamzong
Copy link
Contributor Author

Thanks for @doupache's review. I have updated the code.

Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilfred-s wilfred-s closed this in 1a51966 Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants