Skip to content

Conversation

@minahlee
Copy link
Member

@minahlee minahlee commented Jun 16, 2016

What is this PR for?

Realized that #1020 doesn't do the job. This PR does fix the issue of broken image on website and already deployed on the website

What type of PR is it?

Bug Fix

@corneadoug
Copy link
Contributor

Yes, we fixed the /assets type of links a few times before.

The best way to check the image link it to use the 'sources' tab in the developer tools to see the file tree.
screen shot 2016-06-16 at 1 23 31 pm

LGTM

@minahlee
Copy link
Member Author

Thank you for the tip! wont make same mistake again...

@corneadoug
Copy link
Contributor

@minahlee Should it be merged also in 0.6.0 branch?

@minahlee
Copy link
Member Author

@corneadoug yes, the doc for 0.6.0 will be published based on branch-0.6

@minahlee
Copy link
Member Author

@corneadoug FYI you don't need to push it to svn since I already did.

@corneadoug
Copy link
Contributor

@minahlee I think you can merge it :)

@minahlee
Copy link
Member Author

Ok let me merge it then :)

@asfgit asfgit closed this in 0ed590e Jun 16, 2016
asfgit pushed a commit that referenced this pull request Jun 16, 2016
### What is this PR for?
Realized that #1020 doesn't do the job. This PR does fix the issue of broken image on website and already deployed on the website

### What type of PR is it?
Bug Fix

Author: Mina Lee <minalee@apache.org>

Closes #1022 from minahlee/hotfix/doc_image2 and squashes the following commits:

17309ee [Mina Lee] Fix path again

(cherry picked from commit 0ed590e)
Signed-off-by: Mina Lee <minalee@apache.org>
@minahlee minahlee deleted the hotfix/doc_image2 branch June 23, 2016 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants