[HOTFIX][DOC] Fix image path #1020
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
👍 looks great, let's merge and update website! |
asfgit
pushed a commit
that referenced
this pull request
Jun 16, 2016
### What is this PR for? Use relative path instead of absolute path so doc can find image under proper version folder ### What type of PR is it? Documentation ### Screenshots (if appropriate) Current 0.6.0-SNAPSHOT main page looks like this: <img width="931" alt="screen shot 2016-06-15 at 5 24 25 pm" src="https://cloud.githubusercontent.com/assets/8503346/16102042/9ca90772-3320-11e6-8628-5850003a64a9.png"> Author: Mina Lee <minalee@apache.org> Closes #1020 from minahlee/hotfix/doc_image and squashes the following commits: 9574e0a [Mina Lee] Fix image path (cherry picked from commit 74c034e) Signed-off-by: Mina Lee <minalee@apache.org>
Contributor
|
I feel like we battled against the opposite case before: |
asfgit
pushed a commit
that referenced
this pull request
Jun 16, 2016
### What is this PR for? Realized that #1020 doesn't do the job. This PR does fix the issue of broken image on website and already deployed on the website ### What type of PR is it? Bug Fix Author: Mina Lee <minalee@apache.org> Closes #1022 from minahlee/hotfix/doc_image2 and squashes the following commits: 17309ee [Mina Lee] Fix path again
asfgit
pushed a commit
that referenced
this pull request
Jun 16, 2016
### What is this PR for? Realized that #1020 doesn't do the job. This PR does fix the issue of broken image on website and already deployed on the website ### What type of PR is it? Bug Fix Author: Mina Lee <minalee@apache.org> Closes #1022 from minahlee/hotfix/doc_image2 and squashes the following commits: 17309ee [Mina Lee] Fix path again (cherry picked from commit 0ed590e) Signed-off-by: Mina Lee <minalee@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Use relative path instead of absolute path so doc can find image under proper version folder
What type of PR is it?
Documentation
Screenshots (if appropriate)
Current 0.6.0-SNAPSHOT main page looks like this:
