Fix a few image not rendering #899
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
shijinkui
pushed a commit
to shijinkui/incubator-zeppelin
that referenced
this pull request
May 26, 2016
### What is this PR for? There was a recent PR made by doanduyhai that was changing some images URL to include `../assets`. However, I found a few more cases in the deployed website. It is actually a bit hard to understand why this happens in some cases only, maybe it could be better to replace all `/assets` to `../assets`, however this PR is only fixing the current issues. ### What type of PR is it? Bug Fix ### How should this be tested? You can build the doc and run it locally ### Screenshots (if appropriate) <img width="688" alt="screen shot 2016-05-18 at 3 20 53 pm" src="https://cloud.githubusercontent.com/assets/710411/15376817/45648b78-1d0c-11e6-82cb-4ba106e01043.png"> <img width="521" alt="screen shot 2016-05-18 at 3 21 09 pm" src="https://cloud.githubusercontent.com/assets/710411/15376819/493ff976-1d0c-11e6-9960-cbd568f5d0ec.png"> ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Damien CORNEAU <corneadoug@gmail.com> Closes apache#899 from corneadoug/fix/docsImagesLink and squashes the following commits: c7333d7 [Damien CORNEAU] Fix a few image not rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
There was a recent PR made by @doanduyhai that was changing some images URL to include
../assets. However, I found a few more cases in the deployed website.It is actually a bit hard to understand why this happens in some cases only, maybe it could be better to replace all
/assetsto../assets, however this PR is only fixing the current issues.What type of PR is it?
Bug Fix
How should this be tested?
You can build the doc and run it locally
Screenshots (if appropriate)
### Questions: - Does the licenses files need update? No - Is there breaking changes for older versions? No - Does this needs documentation? No