-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[HOTFIX] Fix flaky AuthenticationIT #1084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
prabhjyotsingh
wants to merge
1
commit into
apache:master
from
prabhjyotsingh:hotfix/testGroupPermission
Closed
[HOTFIX] Fix flaky AuthenticationIT #1084
prabhjyotsingh
wants to merge
1
commit into
apache:master
from
prabhjyotsingh:hotfix/testGroupPermission
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d387163 to
47cf1aa
Compare
1 task
5dcbabe to
50b479b
Compare
Contributor
Author
|
CI green ready for review! |
Member
|
Awesome!!! let's merge it |
Contributor
Author
|
Thanks a lot, I'll merge this as a hot fix. |
asfgit
pushed a commit
that referenced
this pull request
Jun 25, 2016
### What is this PR for? This is hotfix for CI failing for Tests in error: AuthenticationIT.testGroupPermission:177->authenticationUser:109->AbstractZeppelinIT.pollingWait:114 » Timeout ### What type of PR is it? [Hot Fix] ### Todos * [x] - Add check for request.status === 500, while logout ### What is the Jira issue? - [ZEPPELIN-1009](https://issues.apache.org/jira/browse/ZEPPELIN-1009) ### How should this be tested? Check for CI green ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? n/a * Is there breaking changes for older versions? n/a * Does this needs documentation? n/a Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closes #1084 from prabhjyotsingh/hotfix/testGroupPermission and squashes the following commits: 50b479b [Prabhjyot Singh] check for request.status === 500 (cherry picked from commit 510cecd) Signed-off-by: Prabhjyot Singh <prabhjyotsingh@gmail.com>
Contributor
Author
|
@minahlee @bzz @Leemoonsoo After merging this CI is now failing (Build #5323.1) with https://s3.amazonaws.com/archive.travis-ci.org/jobs/140172363/log.txt |
This was referenced Jun 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This is hotfix for CI failing for
Tests in error:
AuthenticationIT.testGroupPermission:177->authenticationUser:109->AbstractZeppelinIT.pollingWait:114 » Timeout
What type of PR is it?
[Hot Fix]
Todos
What is the Jira issue?
How should this be tested?
Check for CI green
Screenshots (if appropriate)
Questions: