Skip to content

[Bugfix] init RepoSetting values#1097

Closed
astroshim wants to merge 1 commit intoapache:masterfrom
astroshim:bugfix/initRepositoryValues
Closed

[Bugfix] init RepoSetting values#1097
astroshim wants to merge 1 commit intoapache:masterfrom
astroshim:bugfix/initRepositoryValues

Conversation

@astroshim
Copy link
Contributor

What is this PR for?

This PR fixes initialize value bug of Add New Repository.

What type of PR is it?

Bug Fix

How should this be tested?

  1. launch the Add New Repository modal window.
  2. put URL value
  3. hit Cancel button
  4. launch the Add New Repository modal window again.

Screenshots (if appropriate)

  • before
    bb
  • after
    after

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@astroshim astroshim changed the title init newRepoSetting values [Bugfix] init RepoSetting values Jun 27, 2016
@astroshim
Copy link
Contributor Author

astroshim commented Jun 28, 2016

It seems that the CI error is not related this PR.

Tests in error: 
  ZeppelinIT.testSparkInterpreterDependencyLoading:217->AbstractZeppelinIT.createNewNote:119 » Timeout

I updated CI issue on https://issues.apache.org/jira/browse/ZEPPELIN-878

@jongyoul
Copy link
Member

Could you please re-trigger it?

@astroshim astroshim closed this Jun 29, 2016
@astroshim astroshim reopened this Jun 29, 2016
@astroshim
Copy link
Contributor Author

astroshim commented Jun 29, 2016

I re-triggered but other error occurred.
It seems that the CI fail is related to #1084.

Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.579 sec <<< FAILURE! - in org.apache.zeppelin.python.PythonInterpreterTest
testClose(org.apache.zeppelin.python.PythonInterpreterTest)  Time elapsed: 0.429 sec  <<< FAILURE!
java.lang.AssertionError: null
    at org.junit.Assert.fail(Assert.java:86)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at org.junit.Assert.assertFalse(Assert.java:64)
    at org.junit.Assert.assertFalse(Assert.java:74)
    at org.apache.zeppelin.python.PythonInterpreterTest.testClose(PythonInterpreterTest.java:141)


Results :

Failed tests: 
  PythonInterpreterTest.testClose:141 null

@jongyoul
Copy link
Member

It's flaky test but we need to ensure all the test passed. Could you please do it once again?

@astroshim astroshim closed this Jun 29, 2016
@astroshim astroshim reopened this Jun 29, 2016
@astroshim
Copy link
Contributor Author

CI has passed. Thanks.

@jongyoul
Copy link
Member

I'll merge it

@asfgit asfgit closed this in d4e3d8c Jun 29, 2016
asfgit pushed a commit that referenced this pull request Jul 18, 2016
### What is this PR for?
This PR fixes initialize value bug of ```Add New Repository```.

### What type of PR is it?
Bug Fix

### How should this be tested?
1. launch the ```Add New Repository``` modal window.
2. put URL value
3. hit Cancel button
4. launch the ```Add New Repository``` modal window again.

### Screenshots (if appropriate)
  - before
![bb](https://cloud.githubusercontent.com/assets/3348133/16388909/5fbddd00-3cd6-11e6-9e46-1afbb8a37356.gif)

  - after
![after](https://cloud.githubusercontent.com/assets/3348133/16388911/6294390c-3cd6-11e6-92ae-01a8730e3c25.gif)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: astroshim <hsshim@nflabs.com>

Closes #1097 from astroshim/bugfix/initRepositoryValues and squashes the following commits:

f5a08d5 [astroshim] init newRepoSetting values

(cherry picked from commit d4e3d8c)
Signed-off-by: Mina Lee <minalee@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants