[ZEPPELIN-6090] Drop JDK8 from CI #4875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
reviewed
Oct 17, 2024
.github/workflows/core.yml
Outdated
| run: | | ||
| ./mvnw install -DskipTests -pl livy -am ${MAVEN_ARGS} | ||
| ./testing/downloadSpark.sh "2.4.8" "2.7" | ||
| ./testing/downloadLivy.sh "0.8.0-incubating" "2.11" |
There was a problem hiding this comment.
Livy 0.8 also provides 2.12 binary, which should work with Spark 3 and may support Java 11, though I haven't tested.
There was a problem hiding this comment.
I'll give it a try.Reamer@e6f0067
|
@Reamer Livy 0.8 seems tested with Spark 3.2.3 |
|
I am currently testing with Spark version 3.5 and the tests are running except for one. |
|
I tested Livy 0.8.0 with Spark 3.2.4, using JDK 11, saw another failure, and have no idea ... |
pan3793
reviewed
Oct 22, 2024
| - python: 3.7 | ||
| java: 8 | ||
| - python: 3.8 | ||
| java: 8 |
There was a problem hiding this comment.
this silently drops test for Python 3.7 and 3.8, if this is intended, please at least mention that in PR title/desc
There was a problem hiding this comment.
The description has been adjusted.
There was a problem hiding this comment.
... also drops python 3.8 & 3.9
typo? should be 3.7 & 3.8
There was a problem hiding this comment.
Definitely, thank you for your close look.
Adjusted.
pan3793
approved these changes
Oct 22, 2024
asfgit
pushed a commit
that referenced
this pull request
Oct 22, 2024
### What is this PR for? This pull request removes the test with JDK 8. I have kept the JDK matrix to make it easier to switch to the next JDK later. This pull request also drops python 3.7 & 3.8 tests for the `python`,`rlang` and `zeppelin-jupyter` interpreter. Please note that current python 3.7 and 3.8 are end of life. https://devguide.python.org/versions/ ### What type of PR is it? Improvement ### What is the Jira issue? - https://issues.apache.org/jira/browse/ZEPPELIN-6090 ### How should this be tested? * CI ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #4875 from Reamer/jdk11_github. Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com> (cherry picked from commit b9860b6) Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This pull request removes the test with JDK 8. I have kept the JDK matrix to make it easier to switch to the next JDK later.
This pull request also drops python 3.7 & 3.8 tests for the
python,rlangandzeppelin-jupyterinterpreter. Please note that current python 3.7 and 3.8 are end of life. https://devguide.python.org/versions/What type of PR is it?
Improvement
What is the Jira issue?
How should this be tested?
Questions: