Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-6090] Drop JDK8 from CI #4875

Merged
merged 1 commit into from
Oct 22, 2024
Merged

[ZEPPELIN-6090] Drop JDK8 from CI #4875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 8 additions & 19 deletions .github/workflows/core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [ 8, 11 ]
java: [ 11 ]
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -91,7 +91,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [ 8, 11 ]
java: [ 11 ]
env:
INTERPRETERS: 'hbase,jdbc,file,flink-cmd,cassandra,elasticsearch,bigquery,alluxio,livy,groovy,java,neo4j,sparql,mongodb,influxdb,shell'
steps:
Expand Down Expand Up @@ -137,12 +137,7 @@ jobs:
fail-fast: false
matrix:
python: [ 3.9 ]
java: [ 8, 11 ]
include:
- python: 3.7
java: 8
- python: 3.8
java: 8
java: [ 11 ]
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -190,7 +185,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [ 8, 11 ]
java: [ 11 ]
steps:
# user/password => root/root
- name: Start mysql
Expand Down Expand Up @@ -259,7 +254,7 @@ jobs:
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: 8
java-version: 11
- name: Cache local Maven repository
uses: actions/cache@v4
with:
Expand Down Expand Up @@ -297,7 +292,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [ 8, 11 ]
java: [ 11 ]
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -346,12 +341,7 @@ jobs:
fail-fast: false
matrix:
python: [ 3.9 ]
java: [ 8, 11 ]
include:
- python: 3.7
java: 8
- python: 3.8
java: 8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this silently drops test for Python 3.7 and 3.8, if this is intended, please at least mention that in PR title/desc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description has been adjusted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... also drops python 3.8 & 3.9

typo? should be 3.7 & 3.8

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely, thank you for your close look.
Adjusted.

java: [ 11 ]
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -401,7 +391,6 @@ jobs:
rm -rf spark/interpreter/metastore_db
./mvnw verify -pl spark-submit,spark/interpreter -am -Dtest=org/apache/zeppelin/spark/* -Pspark-3.4 -Pspark-scala-2.13 -Pintegration -DfailIfNoTests=false ${MAVEN_ARGS}
- name: run spark-3.5 tests with scala-2.13 and python-${{ matrix.python }}
if: matrix.python >= '3.8'
run: |
rm -rf spark/interpreter/metastore_db
./mvnw verify -pl spark-submit,spark/interpreter -am -Dtest=org/apache/zeppelin/spark/* -Pspark-3.5 -Pspark-scala-2.13 -Pintegration -DfailIfNoTests=false ${MAVEN_ARGS}
Expand Down Expand Up @@ -460,7 +449,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [ 8, 11 ]
java: [ 11 ]
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
Loading