Skip to content

ZEPPELIN-518 ] always top fixed column title for table#554

Closed
cloverhearts wants to merge 4 commits intoapache:masterfrom
cloverhearts:enhanced/floating_table_header
Closed

ZEPPELIN-518 ] always top fixed column title for table#554
cloverhearts wants to merge 4 commits intoapache:masterfrom
cloverhearts:enhanced/floating_table_header

Conversation

@cloverhearts
Copy link
Member

What is this PR for?

if you express a lot of table Row of Zeppelin, when the Column Title have to scroll down, it is invisible and inconvenient.

So, I have to change the Zeppelin Table Column Title was modified to always display.

What type of PR is it?

Improvement

Todos

  • implement Fixed Column Title for table
  • Browser Test
    • Safari (9.0.2(11601.3.9)
    • Firefox (43.0)
    • Chrome (47.0.2526.106 (64-bit)

Is there a relevant Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-518

How should this be tested?

step 1. many rows table print.
example query)

%pyspark
TABLE = "%table Header1\tHeader2\tHeader3\tHeader4\n"
for x in range(1,101):
    TABLE +=  str(x) + ""
    if (x%4) == 0:
        TABLE += "\n"
    else:
        TABLE += "\t"
z.put("table_context", TABLE)
%spark
println(z.get("table_context"))

step 2. Scroll the mouse over the Table.

Screenshots (if appropriate)

Animated Gif.
fixedtable

Questions:

How tables are expressed in browsers that do not support this feature?

  • As before Header mouse scrolling moves along.

@cloverhearts cloverhearts changed the title Enhanced/floating table header ZEPPELIN-518 ] always top fixed column title for table Dec 18, 2015
@astroshim
Copy link
Contributor

This function is very useful for users!
And the code what you added is the brilliant trick i think. :)
I tested this function at chrome/firefox/explorer and it's working well.

@cloverhearts
Copy link
Member Author

@astroshim Thank you for feed back!

@corneadoug
Copy link
Contributor

Its better to remove the unused thead content (to free some binding)
You could remove the <thead> part in the previous table, and add margin-top: 31px; to it.

@cloverhearts
Copy link
Member Author

@corneadoug Thank you for good advice.
I will modify it as you advise.
unused thead -> margin top 31px;

@cloverhearts
Copy link
Member Author

It is changed.
Delete Unused thead.
Add margin-top table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants