ZEPPELIN-523 ] table scrolling bug fixed. out of area scroll issue #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloverhearts
changed the title
Contributor
|
Cool fix! |
Contributor
|
Tested, LGTM |
Member
Author
|
@astroshim @corneadoug Thank you for Feed back! Have a nice day~ |
Member
|
@cloverhearts Thanks for the fix. LGTM |
 Added auto-complete for pyspark. autocomplete function will operate through the spark python tag '% pyspark'. short-cut = Ctrl + Shift + Space. jira issue : https://issues.apache.org/jira/browse/ZEPPELIN-497 Author: CloverHearts <estail7s@gmail.com> Closes #530 from cloverhearts/ZEPPELIN-497 and squashes the following commits: 6832409 [CloverHearts] Changed PySpark Completion Filter regex d7efe88 [CloverHearts] change filter regex character 1f82825 [CloverHearts] remove variable resultComplaetion f4dc487 [CloverHearts] Pyspark completion __ filtering ab05f86 [CloverHearts] implement pyspark completion
…cluded in CLASSPATH
### What is this PR for?
Find and add jar under ${HADOOP_HOME}/share, recursively.
### What type of PR is it?
Bug Fix
### Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-515
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: Lee moon soo <moon@apache.org>
Closes #551 from Leemoonsoo/ZEPPELIN-515 and squashes the following commits:
350aaa0 [Lee moon soo] find jar under share in recursive way
Member
Author
|
@r-kamath Thank you for Feed back! |
### What is this PR for? Add restarting interpreter REST API information to the document. There is no information in the document even though REST API exist. ### What type of PR is it? Documentation ### Todos * [x] - add restart REST API document. ### Is there a relevant Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-521 ### How should this be tested? You can get the test information from https://github.com/apache/incubator-zeppelin/tree/master/docs. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: astroshim <hsshim@nflabs.com> Closes #555 from astroshim/ZEPPELIN-521 and squashes the following commits: a7ebcf3 [astroshim] to fix build fail. b9cb440 [astroshim] add interpreter restart REST API doc
### What is this PR for? Currently, when there is no change compared with before the interpreter binding setting status, the cancel button in binding page doesn't work. So I fixed this bug. ### What type of PR is it? Bug Fix ### Todos * [x] - Fix the cancel button in interpreter binding page. ### Is there a relevant Jira issue? [https://issues.apache.org/jira/browse/ZEPPELIN-508](https://issues.apache.org/jira/browse/ZEPPELIN-508) ### How should this be tested? Open the Zeppelin any notebook page -> Click the interpreter binding button 1. Don't change any binding setting and Just click the **cancel** button. 2. Or just click twice the interpreter binding button. ### Screenshots (if appropriate) After this PR applied,  ### Questions: * Does the licenses files need update? No. * Is there breaking changes for older versions? No. * Does this needs documentation? No. Author: Ryu Ah young <fbdkdud93@hanmail.net> Closes #548 from AhyoungRyu/ZEPPELIN-508 and squashes the following commits: 3873545 [Ryu Ah young] Remove useless space between parenthesis 2d1d915 [Ryu Ah young] Fix else statement position 63eb0ae [Ryu Ah young] Remove space between colon e946e8d [Ryu Ah young] Remove useless dialog 62b1349 [Ryu Ah young] Fix typo : Notihing -> Nothing f39d4f5 [Ryu Ah young] ZEPPELIN-508 Interpreter binding cancel button doesn't work
### What is this PR for? hide and show of the editor is not functioning properly ### What type of PR is it? Bug fix ### Is there a relevant Jira issue? no ### How should this be tested? Click on on the note name, change the text and enter or focus out to save the new name. Hit Esc for cancel Author: Renjith Kamath <renjith.kamath@gmail.com> Closes #539 from r-kamath/noteNameEditBugFix and squashes the following commits: 8d1ad4b [Renjith Kamath] fix edit note name enter/blur fix
### What is this PR for? When the result in paragraph contains "carriage return" or "line feed", they are getting displayed in single line. The output should be in multiline. ### What type of PR is it? Bug Fix ### Screenshots Before <img width="1439" alt="screen shot 2015-12-16 at 11 26 08 am" src="https://cloud.githubusercontent.com/assets/674497/11833440/a48f1980-a3e8-11e5-908b-8d45f2e2290e.png"> After <img width="1440" alt="screen shot 2015-12-16 at 11 27 22 am" src="https://cloud.githubusercontent.com/assets/674497/11833441/a4929074-a3e8-11e5-974b-45405cb619be.png"> Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closes #538 from prabhjyotsingh/multilineOutputFix and squashes the following commits: c8f63cb [Prabhjyot Singh] multi line output fix, when paragraph result contains "carriage return" or "line feed".
### What is this PR for? Fix default focus issue on bootstrap alert/confirm box ### What type of PR is it? Improvement ### Is there a relevant Jira issue? no ### How should this be tested? Click on any action which prompts the user with a confirm box. Press enter/return for OK. Esc or click outside for cancel Author: Renjith Kamath <renjith.kamath@gmail.com> Closes #532 from r-kamath/bootstrapDialogFix and squashes the following commits: 16b968e [Renjith Kamath] Merge remote-tracking branch 'upstream/master' into bootstrapDialogFix fe63851 [Renjith Kamath] Merge remote-tracking branch 'upstream/master' into bootstrapDialogFix c81bbbe [Renjith Kamath] enable Esc key close for all bootstrap alert and confirm dialogs 7d933f0 [Renjith Kamath] fix bootstrap dialog default button
### What is this PR for? if you express a lot of table Row of Zeppelin, when the Column Title have to scroll down, it is invisible and inconvenient. So, I have to change the Zeppelin Table Column Title was modified to always display. ### What type of PR is it? Improvement ### Todos - [x] implement Fixed Column Title for table - [x] Browser Test - [x] Safari (9.0.2(11601.3.9) - [x] Firefox (43.0) - [x] Chrome (47.0.2526.106 (64-bit) ### Is there a relevant Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-518 ### How should this be tested? step 1. many rows table print. example query) ``` python %pyspark TABLE = "%table Header1\tHeader2\tHeader3\tHeader4\n" for x in range(1,101): TABLE += str(x) + "" if (x%4) == 0: TABLE += "\n" else: TABLE += "\t" z.put("table_context", TABLE) ``` ``` scala %spark println(z.get("table_context")) ``` step 2. Scroll the mouse over the Table. ### Screenshots (if appropriate) Animated Gif.  ### Questions: How tables are expressed in browsers that do not support this feature? - As before Header mouse scrolling moves along. Author: CloverHearts <estail7s@gmail.com> Closes #554 from cloverhearts/enhanced/floating_table_header and squashes the following commits: 53a0b09 [CloverHearts] unused table header to margin 31px 4864da7 [CloverHearts] change for - variable name 38d70b4 [CloverHearts] Support Firefox ba7ca8e [CloverHearts] Fixed Table Header
Contributor
|
@cloverhearts I just merged #554, since those two PRs are making changes on the same component, could you rebase this PR so that we can check that everything still work? |
Member
Author
|
@corneadoug okay. |
Member
Author
|
@corneadoug I'm sorry to bother you. |
Contributor
|
@cloverhearts don't really understand, but to rebase you need to do: |
Just modifying doc so I don't file a new issue to JIRA. Author: Jungtaek Lim <kabhwan@gmail.com> Closes #545 from HeartSaVioR/fix-typo-from-rest-notebook and squashes the following commits: bf27a98 [Jungtaek Lim] re-fix wrongly fixed grammar caf65e5 [Jungtaek Lim] fix typo / grammar from rest-notebook.md
…arts/incubator-zeppelin into bug_fix/table_scrolling
Member
Author
|
rebase complete |
Contributor
|
Wired bug, scroll dosent show after running the paragraph. Happens in all the browsers.
Apart for this, works good, tested on IE10, FF, Chrome and Safari. |
Member
Author
|
@prabhjyotsingh |
Member
Author
|
I close this PR. |
9 tasks
asfgit
pushed a commit
that referenced
this pull request
Jan 3, 2016
### What is this PR for?
For Table, reimplemented, scrolling, deleting a bug in the Table Header, Scrolling area expressed bugs have been fixed.
### What type of PR is it?
Bug Fix
### Todos
- [x] \(Re-modification\) always top fixed column title for table
- [x] table scrolling bug fixed. out of area scroll
#556
- [x] After the re-run, remove the scroll bar
- [x] License Infomation
- [x] record the license information of jquery.floatThead.
- [x] Browser Test
- [x] Safari (9.0.2(11601.3.9)
- [x] Firefox (43.0)
- [x] Chrome (47.0.2526.106 (64-bit)
### Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-523
### How should this be tested?
Step 1. create table on zeppelin
example query)
``` python
%pyspark
TABLE = "%table Header1\tHeader2\n"
for x in range(1,51):
#TABLE += "scroll";
TABLE += str(x);
if (x%2) == 0:
TABLE += "\n"
else:
TABLE += "\t"
z.put("table_context", TABLE)
```
``` scala
println(z.get("table_context"))
```
Step 2.
Scroll the mouse over the Table.
Step 3.
re Run Paragraph.
Step 4.
Scroll the mouse over the Table.
### Screenshots (if appropriate)
#### Before
#### After
### Questions:
You are using an external source?
\- I used jquery.floatThead (MIT) Libraries.
It helps to secure the Table Header.
Why did this problem occur?
\- ref. https://github.com/noraesae/perfect-scrollbar#how-to-use perfect scrollbar library.
height calculation miss.
Why it has created a new PR?
\- A problem with a private Git Repository to my mistakes.
Please previous PR, see the following URL.
#556
In the ScreenShot, it seems to have changed color table. What changed things?
\- no. It's Animated Gif color problems.
Changes that do not exist.
Author: CloverHearts <estail7s@gmail.com>
Closes #565 from cloverhearts/bug_fix/table_scrolling_and_hiding and squashes the following commits:
19621bf [CloverHearts] bug fix - Floating Thead corrected the problem does not go away.
350683e [CloverHearts] remove white space
4eb9546 [CloverHearts] Space remove. (Ci- build)
93ce86d [CloverHearts] changed Paragraph Gear Option z-index
a52e35e [CloverHearts] CI - BUILD Commit
ba165bf [CloverHearts] variable name change
f8123c5 [CloverHearts] Fixed scrollbar when the first Mouseover does not appear in the Table.
bf16e1a [CloverHearts] bug fixed visualize table component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Scrollbar position when you scroll through the table has been modified with parts that are expressed differently in the length of the actual data.
What type of PR is it?
Bug Fix
Todos
Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-523
How should this be tested?
Step 1. create table on zeppelin
example query)
println(z.get("table_context"))Step 2.
Scroll the mouse over the Table.
Screenshots (if appropriate)
Before
After
Questions:
Why did this problem occur?
height calculation miss.