Zeppelin-523 ] Table Header fixed and scrolling bug fixes.

[cloverhearts]

What is this PR for?

For Table, reimplemented, scrolling, deleting a bug in the Table Header, Scrolling area expressed bugs have been fixed.

What type of PR is it?

Bug Fix

Todos

• (Re-modification) always top fixed column title for table
• table scrolling bug fixed. out of area scroll
  ZEPPELIN-523 ] table scrolling bug fixed. out of area scroll issue #556
• After the re-run, remove the scroll bar
• License Infomation
  • record the license information of jquery.floatThead.
• Browser Test
  • Safari (9.0.2(11601.3.9)
  • Firefox (43.0)
  • Chrome (47.0.2526.106 (64-bit)

Is there a relevant Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-523

How should this be tested?

Step 1. create table on zeppelin
example query)

%pyspark
TABLE = "%table Header1\tHeader2\n"
for x in range(1,51):
    #TABLE +=  "scroll";
    TABLE +=  str(x);
    if (x%2) == 0:
        TABLE += "\n"
    else:
        TABLE += "\t"
z.put("table_context", TABLE)

println(z.get("table_context"))

Step 2.
Scroll the mouse over the Table.

Step 3.
re Run Paragraph.

Step 4.
Scroll the mouse over the Table.

Screenshots (if appropriate)

Before

After

Questions:

You are using an external source?

• I used jquery.floatThead (MIT) Libraries.
  It helps to secure the Table Header.
  Why did this problem occur?
• ref. https://github.com/noraesae/perfect-scrollbar#how-to-use perfect scrollbar library.
  height calculation miss.
  Why it has created a new PR?
• A problem with a private Git Repository to my mistakes.
  Please previous PR, see the following URL.
  ZEPPELIN-523 ] table scrolling bug fixed. out of area scroll issue #556
  In the ScreenShot, it seems to have changed color table. What changed things?
• no. It's Animated Gif color problems.
  Changes that do not exist.

[cloverhearts]

Additional modifications
according to a floating Thead, Paragraph Option Fixes a problem.

before

after

This bug fixes to the table was completed.
I would like to discuss and review.

[Leemoonsoo]

Looks good to me.
Merge if there're no more discussions.

[corneadoug]

@Leemoonsoo
I'd like to take a closer look, especially since it's adding a new library

[cloverhearts]

@corneadoug I'm sympathetic to your comments.
Note that I am so attached to a code and library link.
I hope this helps to determine.

https://github.com/noraesae/perfect-scrollbar/issues/273
https://github.com/noraesae/perfect-scrollbar/issues/256
http://mkoryak.github.io/floatThead/examples/perfect-scrollbar/

[Leemoonsoo]

@corneadoug Sure, please take a look closer.

[mkoryak]

author of floatThead here. let me know if i can be of assistance (without installing anything). 🐈

[corneadoug]

I tried it after rebasing with master (because of the resize that was just merged).
Everything seems to work fine, however I found a bug when we switch from table to graph:

[cloverhearts]

@corneadoug
Thank you good feedback.
I will review that section again as your opinion.

[cloverhearts]

@corneadoug

I have completed bug fixes.
Thank you for feedback.

[corneadoug]

LGTM

[Leemoonsoo]

LGTM and merge into master