Skip to content

Conversation

@prabhjyotsingh
Copy link
Contributor

What is this PR for?

Cannot select error/output of the paragraph.
Whenever there is a click on output the focus is set to editor.

What type of PR is it?

[Bug Fix]

Todos

  • - keep scope for mouse drag, doulble/multiple clicks

Is there a relevant Jira issue?

ZEPPELIN-547

How should this be tested?

  • Try single click on output, focus should be set to editor.
  • but if there is a mouse drag or double/triple click on output, it should select output.

Screenshots (if appropriate)

Single click, double click, triple click
click test

@Leemoonsoo
Copy link
Member

@prabhjyotsingh please take a look prabhjyotsingh#1. I think more simple patch is possible.

Another way of handling ZEPPELIN-547
@Leemoonsoo
Copy link
Member

Thanks for fix for the bug.
LGTM and merge if there're no more discussions

@corneadoug
Copy link
Contributor

LGTM

@asfgit asfgit closed this in 1cd08ab Jan 2, 2016
@prabhjyotsingh prabhjyotsingh deleted the ZEPPELIN-547 branch June 1, 2016 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants