Skip to content

ZEPPELIN-547: Cannot select output of the paragraph #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
prabhjyotsingh wants to merge 4 commits into from
Closed

ZEPPELIN-547: Cannot select output of the paragraph #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9a03cd8
keep scope for mouse drag, doulble/multiple clicks
prabhjyotsingh Dec 31, 2015
daf4ed7
Another way of handling ZEPPELIN-547
Leemoonsoo Jan 1, 2016
9ae6155
Merge pull request #1 from Leemoonsoo/ZEPPELIN-547
prabhjyotsingh Jan 1, 2016
ba6cc38
reverting notebook.controller.js changes
prabhjyotsingh Jan 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion zeppelin-web/src/app/notebook/notebook.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ angular.module('zeppelinWebApp').controller('NotebookCtrl',
// register mouseevent handler for focus paragraph
document.addEventListener('click', $scope.focusParagraphOnClick);


$scope.keyboardShortcut = function(keyEvent) {
// handle keyevent
if (!$scope.viewOnly) {
Expand Down
3 changes: 1 addition & 2 deletions zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -841,9 +841,8 @@ angular.module('zeppelinWebApp')
if ($scope.paragraph.id === paragraphId) {
// focus editor
if (!$scope.paragraph.config.editorHide) {
$scope.editor.focus();

if (!mouseEvent) {
$scope.editor.focus();
// move cursor to the first row (or the last row)
var row;
if (cursorPos >= 0) {
Expand Down