ZOOKEEPER-4492: Merge readOnly field into ConnectRequest and Response #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
eolivelli
reviewed
Mar 13, 2022
An old client sends connect request without readonly field, and the new server read that payload with an exception fail to read readonly field, so it switch to zk 3.3 protocol. An old client receives connect response with readonly field from the new server, which is consumed from the wire by the leading length field, and the client doesn't parse it actually, which does no harm. @eolivelli is there any other communication round you find subtle to understand? |
|
Please log a JiRA and update the commit message |
tisonkun
changed the title
|
@eolivelli logged as ZOOKEEPER-4492. For "commit message", I've updated the PR title. Shall I squash all commits into "ZOOKEEPER-4492: ..." also? |
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
|
It seems that travis CI failed on s390x arch due to its own env issues: |
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
symat
approved these changes
Jun 27, 2022
|
merging it |
|
merged to master, thank you @tisonkun for the contribution! |
|
@eolivelli @symat thanks for your reviews! |
anuragmadnawat1
pushed a commit
to anuragmadnawat1/zookeeper
that referenced
this pull request
Nov 2, 2022
According to [this comment in ZOOKEEPER-102](https://issues.apache.org/jira/browse/ZOOKEEPER-102?focusedCommentId=16977000&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16977000) I introduce a `Protocol` abstraction and going to moving all wire protocol concept into `cnxn` and this scope, so that client and server's business logics handle only deserialized/real record. cc eolivelli maoling Randgalt This supersedes apache#1832. Author: tison <wander4096@gmail.com> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1837 from tisonkun/protocol
anuragmadnawat1
added a commit
to anuragmadnawat1/zookeeper
that referenced
this pull request
Nov 2, 2022
…#71) According to [this comment in ZOOKEEPER-102](https://issues.apache.org/jira/browse/ZOOKEEPER-102?focusedCommentId=16977000&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16977000) I introduce a `Protocol` abstraction and going to moving all wire protocol concept into `cnxn` and this scope, so that client and server's business logics handle only deserialized/real record. cc eolivelli maoling Randgalt This supersedes apache#1832. Author: tison <wander4096@gmail.com> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1837 from tisonkun/protocol Co-authored-by: tison <wander4096@gmail.com>
anurag-harness
pushed a commit
to anurag-harness/zookeeper
that referenced
this pull request
Jan 13, 2023
According to [this comment in ZOOKEEPER-102](https://issues.apache.org/jira/browse/ZOOKEEPER-102?focusedCommentId=16977000&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16977000) I introduce a `Protocol` abstraction and going to moving all wire protocol concept into `cnxn` and this scope, so that client and server's business logics handle only deserialized/real record. cc eolivelli maoling Randgalt This supersedes apache#1832. Author: tison <wander4096@gmail.com> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1837 from tisonkun/protocol
Slach
added a commit
to Altinity/clickhouse-backup
that referenced
this pull request
Aug 28, 2023
…ickhouse and zookeeper 3.9.0, see details in apache/zookeeper#1837 (comment) return `:latest` default value after resolve ClickHouse/ClickHouse#53749
minguyen9988
added a commit
to minguyen9988/clickhouse-backup
that referenced
this pull request
Sep 28, 2023
* add connection to gcs and use different context for upload incase it got cancel by another thread * save * keep ctx * keep ctx * use v2 * change to GCS_CLIENT_POOL_SIZE * pin zookeeper to 3.8.2 version for resolve incompatibility between clickhouse and zookeeper 3.9.0, see details in apache/zookeeper#1837 (comment) return `:latest` default value after resolve ClickHouse/ClickHouse#53749 * Revert "add more precise disk re-balancing for not exists disks, during download, partial fix Altinity#561" This reverts commit 20e250c. * fix S3 head object Server Side Encryption parameters, fix Altinity#709 * change timeout to 60m, TODO make tests Parallel --------- Co-authored-by: Slach <bloodjazman@gmail.com>
While this may apply to "old" Java clients, I'm afraid it does not hold for all implementations! ZooKeeper's own C client library, notably, currently cannot connect to 3.9 servers. I have a patch in the works. See ZOOKEEPER-4814. |
vincentbernat
added a commit
to akvorado/akvorado
that referenced
this pull request
Apr 4, 2024
There is an incompatibility of ClickHouse with Zookeeper 3.9. See: - apache/zookeeper#2146 - apache/zookeeper#1837 - ClickHouse/ClickHouse#53749
vincentbernat
added a commit
to akvorado/akvorado
that referenced
this pull request
Apr 4, 2024
There is an incompatibility of ClickHouse with Zookeeper 3.9. See: - apache/zookeeper#2146 - apache/zookeeper#1837 - ClickHouse/ClickHouse#53749
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this comment in ZOOKEEPER-102 I introduce a
Protocolabstraction and going to moving all wire protocol concept intocnxnand this scope, so that client and server's business logics handle only deserialized/real record.cc @eolivelli @maoling @Randgalt
This supersedes #1832.