ZOOKEEPER-4814: Re-introduce support for clients incompatible with the 3.5+ readOnly extension
#2146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ztzg
force-pushed
the
ZOOKEEPER-4814-clients-without-read-only
branch
from
b40c6e7 to
1359063
Compare
vincentbernat
added a commit
to akvorado/akvorado
that referenced
this pull request
Apr 4, 2024
There is an incompatibility of ClickHouse with Zookeeper 3.9. See: - apache/zookeeper#2146 - apache/zookeeper#1837 - ClickHouse/ClickHouse#53749
vincentbernat
added a commit
to akvorado/akvorado
that referenced
this pull request
Apr 4, 2024
There is an incompatibility of ClickHouse with Zookeeper 3.9. See: - apache/zookeeper#2146 - apache/zookeeper#1837 - ClickHouse/ClickHouse#53749
kezhuw
approved these changes
Aug 11, 2024
kezhuw
pushed a commit
that referenced
this pull request
Aug 11, 2024
…e 3.5+ `readOnly` extension Reviewers: tisonkun, kezhuw Author: ztzg Closes #2146 from ztzg/ZOOKEEPER-4814-clients-without-read-only (cherry picked from commit 90f8d83)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ProtocolManagerclass knows whether the client sent areadOnlyflag as part of theConnectRequest, and can use that information to, in turn, avoid the extra byte when serializing theConnectResponse.