-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We need to translate every message in eng #7
Labels
good first issue
Good for newcomers
Comments
What exactly needs to be done here? Which messages need to be translated? Thanks |
Every response message that is returned from the API needs to be in English and not in Greek. for example here
One solution may be a hard code change with English text. Another solution may be with i18n npm module which supports multilingual. |
I would suggest a separate file in which there are written all the required messages. Then you can include that file wherever its needed thus removing the unwanted duplication that yiu want to achieve. Since all messages seem to be custom, a separate file looks like a good alternative. Please let me know what are your thoughts on that.
…________________________________
From: Alexis Pavlidis <notifications@github.com>
Sent: Saturday, December 1, 2018 10:32:38 PM
To: apavlidi/IT_API
Cc: Aldi; Comment
Subject: Re: [apavlidi/IT_API] We need to translate every message in eng (#7)
Every response message that is returned from the API needs to be in English and not in Greek. for example here https://github.com/apavlidi/IT_API/blob/aa3492d589ef1c2abf7828708a53f6e210872c23/routes/bulletinBoard/announcements/index.js#L51
One solution may be a hard code change with English text. Another solution may be with i18n npm module which supports multilingual.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#7 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AVyUbpTTaYWWcjHoacg2pFTW2BdZs3iNks5u0udmgaJpZM4VRA9b>.
|
This is the way to go actually. The i18n npm module supports that and I would recommend using it as I used in the past and solved the language issue. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: