Update functions.js #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable the multilingual library (temporarily)
apavlidi
reviewed
Oct 8, 2019
|
We need to keep the code. |
|
Otherwise, we need an option for the wordpress site "is_multilingual". (This is better) |
|
Version control systems is for that reason, git helps keep track of old changes without commending code in the codebase for historical reasons. Multilanguage is a great feature that`s been on "issues" section here #7 |
Add option for multilingual wordpress site.
Take into account the config option for wordpress
apavlidi
reviewed
Oct 9, 2019
| @@ -49,6 +49,7 @@ const OWASP_CONFIG = { | |||
|
|
|||
| const WORDPRESS_CREDENTIALS = { | |||
| url: 'https://www.iee.ihu.gr', | |||
| is_multilingual: false, | |||
There was a problem hiding this comment.
The code style convection we follow is camel cased, so please try follow this for consistency.
In this case "is_multilingual" shloud be "isMultilingual"
apavlidi
approved these changes
Oct 9, 2019
|
Do whatever changes on code you wish!!!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable the multilingual library (temporarily)