Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] kbcli cluster backup should check if the specified backup method exists #326

Closed
zjx20 opened this issue Apr 22, 2024 · 0 comments · Fixed by #328
Closed

[Improvement] kbcli cluster backup should check if the specified backup method exists #326

zjx20 opened this issue Apr 22, 2024 · 0 comments · Fixed by #328
Assignees
@d976045024
Labels
good first issue Good for newcomers
Milestone
Release 0.9.0

Comments

@zjx20
Copy link
Contributor

zjx20 commented Apr 22, 2024

Is your improvement request related to a problem? Please describe.

The backup command succeeds even if the specified backup method does not exist. For example:

kbcli cluster backup mycluster --method=bad_method

But the backup ops reports error message:

  Warning  DoActionFailed            1s (x12 over 11s)  ops-request-controller  Failed to process the operation of OpsRequest: backup method bad_method is not supported, please check cluster's backup policy

Describe the solution you'd like

kbcli should check the specified backup method before invoking a backup ops.
@zjx20 zjx20 added the good first issue Good for newcomers label Apr 22, 2024
@ldming ldming transferred this issue from apecloud/kubeblocks-addons May 6, 2024
d976045024 added a commit that referenced this issue May 7, 2024
@d976045024
fix: check if the specified backup method exists when creating a back…
1edfd31 
…up (#326)
@d976045024 d976045024 mentioned this issue May 7, 2024
Merged
d976045024 added a commit that referenced this issue May 7, 2024
@d976045024
fix: check if the specified backup method exists when creating a back…
3d5602e 
…up (#326)
d976045024 added a commit that referenced this issue May 7, 2024
@d976045024
fix: modify msg format (#326)
6172d1a
d976045024 added a commit that referenced this issue May 7, 2024
@d976045024
fix: modify msg format (#326)
b3c6e13
@github-actions github-actions bot added this to the Release 0.9.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d976045024 d976045024

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
Release 0.9.0
Development

Successfully merging a pull request may close this issue.

fix: check if the specified backup method exists when creating a backup apecloud/kbcli
2 participants
@zjx20 @d976045024