Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check if the specified backup method exists when creating a backup #328

Merged
merged 4 commits into from
May 7, 2024
Merged

fix: check if the specified backup method exists when creating a backup #328

merged 4 commits into from
May 7, 2024

Conversation

d976045024
Copy link
Contributor

@d976045024 d976045024 commented May 7, 2024 •
edited
Loading

fix: #326

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label May 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 42.84%. Comparing base (bb707c8) to head (6172d1a).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/cmd/cluster/dataprotection.go 60.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #328   +/-   ##
=======================================
  Coverage   42.84%   42.84%           
=======================================
  Files         213      213           
  Lines       29031    29041   +10     
=======================================
+ Hits        12438    12444    +6     
- Misses      15059    15062    +3     
- Partials     1534     1535    +1
Flag Coverage Δ
unittests 42.84% <60.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d976045024 d976045024 requested a review from ldming May 7, 2024 07:46
@d976045024 d976045024 merged commit 2c04abc into main May 7, 2024
12 checks passed
@d976045024 d976045024 deleted the support/backup-method-check branch May 7, 2024 13:32
@github-actions github-actions bot added this to the Release 0.9.0 milestone May 7, 2024
@ldming
Copy link
Collaborator

ldming commented May 7, 2024

/cherry-pick release-0.9

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kbcli/actions/runs/8987774524

github-actions bot pushed a commit that referenced this pull request May 7, 2024
@d976045024 @ldming
fix: check if the specified backup method exists when creating a back…
ed09531 
…up (#328)

(cherry picked from commit 2c04abc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldming ldming ldming approved these changes

@nayutah nayutah Awaiting requested review from nayutah nayutah is a code owner

@heng4fun heng4fun Awaiting requested review from heng4fun heng4fun is a code owner

@free6om free6om Awaiting requested review from free6om free6om is a code owner

@wangyelei wangyelei Awaiting requested review from wangyelei wangyelei is a code owner

@leon-inf leon-inf Awaiting requested review from leon-inf leon-inf is a code owner

@1aal 1aal Awaiting requested review from 1aal 1aal is a code owner

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
Release 0.9.0
Development

Successfully merging this pull request may close these issues.

[Improvement] kbcli cluster backup should check if the specified backup method exists
3 participants
@d976045024 @codecov-commenter @ldming