Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit API name not updated in browser URL #2805

Closed
saralavanip opened this issue Aug 3, 2017 · 3 comments · Fixed by #2991
Closed

Edit API name not updated in browser URL #2805

saralavanip opened this issue Aug 3, 2017 · 3 comments · Fixed by #2991
Assignees
Milestone

Comments

@saralavanip
Copy link
Contributor

Steps

1.Visit https://staging.apinf.io (v 0.48.0)
2.Login
3.Add API (eg: Test-API-abc)
4.Go to above added API 'Settings'
5.Edit the name of API (eg.Test-API-xyz)
6.Click on 'Save'
7.Go to above 'API' profile from catalog

Expected Result

Successful in edit-save name of API and the updated name shown in browser URL

Actual Result

  • Successful edit-save name of API but not updated in browser URL.Shows the previous name
  • Shows updated API name in Catalog,Profile and Settings views though

Browsers

Chrome v 52.0.2743.116 (64-bit)

Operating system

Ubuntu 16.04 LTS

Screenshot

selection_167

selection_169

@bajiat
Copy link
Contributor

bajiat commented Aug 16, 2017

Slug needs to be updated, when name is changed.

@bajiat
Copy link
Contributor

bajiat commented Aug 21, 2017

@brylie Can you find reference code from previous implementation for @saransh-dev ?

@saransh-dev
Copy link
Contributor

@bajiat I have found the code where I need to implement and I have implemented it. Now slug will change while API name will change. I am facing following issues:-

  1. After update, slug won't change in URL (DT-Comment:- Fixed it)
  2. If we update anything in API instead of API's name, it works fine and we can fetch data in onSuccess() inside autoform hook (inside function there is findOne quarry on the basis of _id, it returns undefined). But while update API's name, it does not get data in onSuccess() inside autoform hook (inside function there is findOne quarry on the basis of _id, it returns undefined).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants