Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show newest monitoring data on top #3635

Merged
merged 4 commits into from
Nov 23, 2018

Conversation

matleppa
Copy link
Member

Closes #3589

Changes

  • newest monitoring data is shown on top

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @username1

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

@ghost ghost assigned matleppa Nov 22, 2018
@ghost ghost added the in progress label Nov 22, 2018
@ghost ghost assigned ilarimikkonen Nov 23, 2018
Copy link
Member

@ilarimikkonen ilarimikkonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I canged some stuff

@matleppa matleppa merged commit 0d3b4df into develop Nov 23, 2018
@ghost ghost removed the Ready for review label Nov 23, 2018
@matleppa matleppa deleted the feature/api-monitoring-layout-fixes branch November 23, 2018 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants