Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in percentage field reset(issues#121) #160

Closed
wants to merge 1 commit into from
Closed

Fix bug in percentage field reset(issues#121) #160

wants to merge 1 commit into from

Conversation

Autumn-Rains-yan
Copy link

Describe the bug
After i filled in a default value of percent field, i couldn't get it back to "empty" state, it always showed a "0" in the input box

To Reproduce
Steps to reproduce the behavior:

Create a field and type is Percent
filled a "5" into the input box of Default value in the field setting modal, and then click the button "OK"
double-click the field name for reopenning the field setting modal, empty the input box of Default value, and then click the button "OK"
double-click the field name again, you will see "0" in the input box of Default value
Expected behavior
Leave it empty when I remove all content from the input box.

Desktop (please complete the following information):

OS: Windows 10
Browser Chrome
Version 108.0.5359.125

@CLAassistant
Copy link

CLAassistant commented Jan 6, 2023

CLA assistant check
All committers have signed the CLA.

@kwp-lab kwp-lab requested a review from Sky-FE January 7, 2023 03:10
@Sky-FE
Copy link
Contributor

Sky-FE commented Jan 18, 2023

Hi, @Autumn-Rains-yan.
You have found the error position, but the PR will cause the "0" to not be filled.
I think we should fix it like this: #215.
Thank you for your interest in APITable. If you've got any questions, just let me know when you feel free.

@Sky-FE Sky-FE closed this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants