Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the default value of the percent field cannot be reset #215

Merged
merged 3 commits into from
Jan 18, 2023
Merged

fix: the default value of the percent field cannot be reset #215

merged 3 commits into from
Jan 18, 2023

Conversation

Sky-FE
Copy link
Contributor

@Sky-FE Sky-FE commented Jan 18, 2023

Why?

How?

  • In number editor, modify the update logic of the percent field.

@Sky-FE Sky-FE requested review from wangkailang and boris-w January 18, 2023 08:15
@Sky-FE Sky-FE linked an issue Jan 18, 2023 that may be closed by this pull request
fix: it couldn't be reset to empty when the default value of the percent field is filled in #121
Closed
@Sky-FE Sky-FE merged commit 279b9da into develop Jan 18, 2023
@Sky-FE Sky-FE deleted the fix/percent-field-default-value branch January 18, 2023 08:57
This was referenced Jan 18, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
arucil pushed a commit that referenced this pull request Feb 3, 2023
@Sky-FE
fix: the default value of the percent field cannot be reset (#215)
151354e 
# Why? 
<!-- 
> Related to which issue?
> Why we need this pull request?
> What is the user story for this pull request? 
-->
- #121 

# How?
<!-- 
> Do you have a simple description of how this pull request is
implemented?
-->
- In number editor, modify the update logic of the percent field.
wumanho pushed a commit to wumanho/apitable that referenced this pull request Feb 6, 2023
@Sky-FE
fix: the default value of the percent field cannot be reset (apitable…
52395de 
…#215)

# Why? 
<!-- 
> Related to which issue?
> Why we need this pull request?
> What is the user story for this pull request? 
-->
- apitable#121 

# How?
<!-- 
> Do you have a simple description of how this pull request is
implemented?
-->
- In number editor, modify the update logic of the percent field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boris-w boris-w boris-w approved these changes

@wangkailang wangkailang Awaiting requested review from wangkailang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: it couldn't be reset to empty when the default value of the percent field is filled in
2 participants
@Sky-FE @boris-w