Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support grayscale feature for non-properties namespaces #4316

Closed
nobodyiam opened this issue Apr 20, 2022 · 15 comments · Fixed by #4952
Closed

Support grayscale feature for non-properties namespaces #4316

nobodyiam opened this issue Apr 20, 2022 · 15 comments · Fixed by #4952
Labels
feature request Categorizes issue as related to a new feature. help wanted summer-2023

Comments

@nobodyiam
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently, apollo supports the grayscale feature for properties namespaces.

image

However, it's not available for non-properties namespaces, e.g. xml/yml, which is strongly required by many users, see #2927.

Describe the solution you'd like
Support grayscale feature for non-properties namespaces, to make it easier, we may only support grayscale the whole text instead of some keys.

image
@nobodyiam nobodyiam added summer-2022 feature request Categorizes issue as related to a new feature. labels Apr 20, 2022
@derecknowayback
Copy link

I am interested in this issue.

@nobodyiam
Copy link
Member Author

Thank you for your interest in this feature. If you are a student, you can apply for the feature on the summer-ospp website.

@SunnyBoy-WYH
Copy link
Contributor

interest it.

@nobodyiam nobodyiam mentioned this issue May 19, 2023
Closed
@ywy-github
Copy link
Contributor

我通过修改前端页面使得非properties格式的命名空间具有了灰度和同步的按钮，测试发现目前是可以支持非properties格式的命名空间整体进行灰度和同步的，那么目前的项目需求是支持key级别的灰度和同步吗？

@nobodyiam
Copy link
Member Author

那么目前的项目需求是支持key级别的灰度和同步吗？

从实现成本考虑，可以实现为 namespace 级别的灰度和同步。
如果可能的话，对 yaml/yml 格式可以看看是否能实现 key 级别的灰度和同步。

@hezhaoye
Copy link

请教下，这个特性目前有人已经在开发了吗

@nobodyiam
Copy link
Member Author

目前开源之夏还在报名阶段，我觉得应该还没有人开始开发 cc @klboke

@hezhaoye
Copy link

请教下，目前有人进入开发了吗

@klboke
Copy link
Contributor

klboke commented Jun 30, 2023

https://github.com/ywy-github 在开发中了

@hezhaoye
Copy link

你好，预计什么时候能完成开发呢？

@ywy-github
Copy link
Contributor

如果能顺利解决该问题，提交PR应该在9月30日之前

@hezhaoye
Copy link

之夏还在报名阶段，我觉得应该还没有人开始开发 cc @k

如果能顺利解决该问题，提交PR应该在9月30日之前

老哥，目前开发进度如何了呢

@ywy-github
Copy link
Contributor

目前还在开发中，yaml的key级别的灰度遇到一些问题还在思考解决方法

@hezhaoye
Copy link

hezhaoye commented Aug 3, 2023

目前还在开发中，yaml的key级别的灰度遇到一些问题还在思考解决方法

如果实现为 namespace 级别的灰度和同步，感觉只要修改下前端页面就好了，后端不用变动。感觉支持整个文本的灰度就能解决大部分问题了。

@ywy-github
Copy link
Contributor

是的，之前在尝试实现yaml格式的配置key级别的灰度，但是对于注释却不能正确保存，实现全文本的灰度只需要更改前端代码基本就可以使用，目前在测试阶段

This was referenced Aug 6, 2023
Closed
Closed
Merged
klboke pushed a commit that referenced this issue Sep 20, 2023
@ywy-github
Support grayscale feature for non-properties namespaces(#4316) (#4952)
57cca96 
* Support grayscale feature for non-properties namespaces(#4316)

* Update the display style of the popup(#4316)

* Modify the code style(#4316)

* add modal to compare differences

* add button

* add comparison function

* update code style

* update code style

* Support grayscale feature for non-properties namespaces(#4316)

* Support grayscale feature for non-properties namespaces(#4316)

* Support grayscale feature for non-properties namespaces(#4316)

* Support grayscale feature for non-properties namespaces(#4316)

* Support grayscale feature for non-properties namespaces(#4316)

* Support grayscale feature for non-properties namespaces(#4316)

* Support grayscale feature for non-properties namespaces(#4316)

* Support grayscale feature for non-properties namespaces(#4316)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Categorizes issue as related to a new feature. help wanted summer-2023
Projects
None yet
Milestone
No milestone
6 participants
@nobodyiam @hezhaoye @klboke @SunnyBoy-WYH @ywy-github @derecknowayback