Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4152 #4175

Merged
merged 1 commit into from
Dec 25, 2021
Merged

Fix #4152 #4175

merged 1 commit into from
Dec 25, 2021

Conversation

lonre
Copy link
Contributor

@lonre lonre commented Dec 24, 2021

beanFactory.isTypeMatch may lead to the initialization of FactoryBean,
dubbo consumer is a ReferenceBean which implements FactoryBean.
support spring 3

related to #2328 #3865 #4161 #4164

What's the purpose of this PR

XXXXX

Which issue(s) this PR fixes:

Fixes #

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

`beanFactory.isTypeMatch` may lead to the initialization of FactoryBean,
dubbo consumer is a ReferenceBean which implements FactoryBean.
support spring 3

related to apolloconfig#2328 apolloconfig#3865 apolloconfig#4161 apolloconfig#4164
@codecov-commenter
Copy link

Codecov Report

Merging #4175 (95652b1) into master (a62881d) will increase coverage by 0.03%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4175      +/-   ##
============================================
+ Coverage     52.56%   52.60%   +0.03%     
- Complexity     2614     2619       +5     
============================================
  Files           484      484              
  Lines         15190    15192       +2     
  Branches       1572     1571       -1     
============================================
+ Hits           7985     7991       +6     
+ Misses         6648     6645       -3     
+ Partials        557      556       -1     
Impacted Files Coverage Δ
...ework/apollo/spring/util/BeanRegistrationUtil.java 87.50% <81.81%> (+14.77%) ⬆️
.../apollo/internals/RemoteConfigLongPollService.java 77.10% <0.00%> (-1.21%) ⬇️
.../framework/apollo/spring/property/SpringValue.java 89.47% <0.00%> (+1.75%) ⬆️
...rk/apollo/spring/property/SpringValueRegistry.java 89.18% <0.00%> (+5.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a62881d...95652b1. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nobodyiam nobodyiam merged commit 7c6c535 into apolloconfig:master Dec 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2021
@nobodyiam nobodyiam added this to the 2.0.0 milestone Jan 1, 2022
@lonre lonre deleted the fix-4152 branch April 11, 2022 15:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants