Update @apollo/client peer dependency to rc and remove makeSuspenseCache
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerelmiller
changed the title
@apolloc/client peer dependency to rc and remove makeSuspenseCache@apollo/client peer dependency to rc and remove makeSuspenseCache
phryneas
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Looks good to me!
I'm still waiting for a review on #59 and will release that as a patch release.
After that, I'll merge this and do a 0.4.0 with it!
In that spirit, I'm already going to pull the README changes from this PR into main - makeSuspenseCache was already optional before and the package.json has already included the .rc releases in the last patch. (see 9092132 )
phryneas
added a commit
that referenced
this pull request
Jul 14, 2023
|
Already pulling in some more changes to make the CI happy on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest changes in the
@apollo/clientrcversion, theSuspenseCacheoption has been removed and will instead be lazy instantiated by the client when a suspense hook is used. This PR updates to only support the latest@apollo/client@rcversion as a peer dependency and removes themakeSuspenseCacheoption.