restart simulated streamed request on stream close #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phryneas
commented
Jul 14, 2023
Comment on lines
46
to
47
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore |
There was a problem hiding this comment.
This is just to get the CI to shut up until #61 is merged - I'll remove that later.
phryneas
commented
Jul 14, 2023
Comment on lines
+169
to
+177
| queryManager | ||
| .fetchQuery(queryId, { | ||
| ...queryInfo.options, | ||
| context: { | ||
| ...queryInfo.options.context, | ||
| queryDeduplication: false, | ||
| }, | ||
| }) | ||
| .finally(() => queryManager.stopQuery(queryId)) |
There was a problem hiding this comment.
phryneas
force-pushed
the
pr/restart-chopped-off-queries
branch
from
ce1fe39 to
7dad495
Compare
|
/release:pr |
|
A new release has been made for this PR. You can install it with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would solve the situation where the server renders a
useBackgroundQuery, but does not consume thequeryRef, so the stream closes before the result can be transported over.