Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rc0 breaks our nextjs site #6385

Closed
marvin-bitterlich opened this issue Jun 4, 2020 · 6 comments
Closed

rc0 breaks our nextjs site #6385

marvin-bitterlich opened this issue Jun 4, 2020 · 6 comments
Assignees
Milestone

Comments

@marvin-bitterlich
Copy link

Intended outcome:
We were updating our apollo-client version to v3.0.0-rc.0 and expected it to work

Actual outcome:
Any call that used the apollo client timed out, which for us was server side rendered pages. We did not find any errors or log messages.

How to reproduce the issue:
We are currently in the process of investigation, but wanted to already alert the apollo-client team of this rc possibly silently breaking sites. I will update this issue if I figure out a way to reproduce this.

Our unit tests using a mocked schema did not break and were all green but when used against a real endpoint timeouts happen. There were no actual requests going out, as even if the graphql endpoint was not running it still timed out.

Versions
The issue was irrespective of os or browser and timed out in ssr rendered pages in nextjs
npmPackages:
@apollo/client: ^3.0.0-rc.0 => 3.0.0-rc.0
@apollo/link-schema: ^2.0.0-beta.3 => 2.0.0-beta.3
@apollo/react-common: ^3.1.4 => 3.1.4
@apollo/react-testing: ^3.1.3 => 3.1.4
apollo: 2.28.0 => 2.28.0
apollo-cache-inmemory: ^1.6.6 => 1.6.6
apollo-client: ^2.6.10 => 2.6.10
apollo-link-context: ^1.0.20 => 1.0.20
apollo-link-persisted-queries: ^0.2.2 => 0.2.2
apollo-link-schema: ^1.2.5 => 1.2.5
apollo-storybook-react: ^0.2.4 => 0.2.4
react-apollo: ^4.0.0-beta.1 => 4.0.0-beta.1

@gtwright
Copy link

gtwright commented Jun 4, 2020

Looks like this ssr issue is reported on the Next repo, too: vercel/next.js#13702

@benjamn
Copy link
Member

benjamn commented Jun 4, 2020

What version were you upgrading from? If you were previously using apollo-client (AC2), the new @apollo/client (AC3) package is a major update, with a number of absolutely necessary migration steps. Hopefully you already know this, but I honestly cannot guess this information from your description.

@benjamn benjamn added the 🏓 awaiting-contributor-response requires input from a contributor label Jun 4, 2020
@marvin-bitterlich
Copy link
Author

marvin-bitterlich commented Jun 4, 2020

What version were you upgrading from? If you were previously using apollo-client (AC2), the new @apollo/client (AC3) package is a major update, with a number of absolutely necessary migration steps. Hopefully you already know this, but I honestly cannot guess this information from your description.

I was upgrading from beta.50 which was I believe a few days ago.

Reverting back to beta.50 fixes the problem.

@benjamn benjamn removed the 🏓 awaiting-contributor-response requires input from a contributor label Jun 4, 2020
@benjamn
Copy link
Member

benjamn commented Jun 4, 2020

@reggaemuffin If the problem has to do with SSR, then I believe #6388 may help (published in @apollo/client@3.0.0-rc.1 just now). Let us know!

@benjamn benjamn added this to the Release 3.0 milestone Jun 4, 2020
@benjamn benjamn self-assigned this Jun 4, 2020
benjamn added a commit that referenced this issue Jun 5, 2020
This reverts commits b6da9c8 (#6388) and
c76804e (#6216).

Preventing StrictMode warnings in React is not worth introducing bugs that
break applications. We will need to reconsider how best to prevent
warnings for unmounted components.
benjamn added a commit that referenced this issue Jun 5, 2020
This reverts commits b6da9c8 (#6388) and
c76804e (#6216).

Preventing StrictMode warnings in React is not worth introducing bugs that
break applications. We will need to reconsider how best to prevent
warnings for unmounted components.
@hwillson
Copy link
Member

This should be fixed in more recent versions of @apollo/client. Thanks!

@marvin-bitterlich
Copy link
Author

I can confirm this, we updated to I believe rc30 and are on a working version that has this bug fixed :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants