Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow onNewData to be called when unmounted, during SSR. #6388

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Allow onNewData to be called when unmounted, during SSR. #6388

merged 1 commit into from
Jun 4, 2020

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented Jun 4, 2020

PR #6216 introduced these isMounted guards, and was merged just before the v3.0.0-rc.0 release. It appears (see #6386) that requiring the component to be mounted is too restrictive, specifically when doing server-side rendering, since the concept of mounting doesn't make sense without a DOM.

@benjamn
Allow onNewData to be called when unmounted, during SSR.
cbab9a9 
PR #6216 introduced these isMounted guards, and was merged just before the
v3.0.0-rc.0 release. It appears (see #6386) that requiring the component
to be mounted is too restrictive, specifically when doing server-side
rendering, since the concept of mounting doesn't make sense without a DOM.
@benjamn benjamn added this to the Release 3.0 milestone Jun 4, 2020
@benjamn benjamn requested a review from hwillson June 4, 2020 21:41
@benjamn benjamn self-assigned this Jun 4, 2020
@benjamn benjamn merged commit b6da9c8 into master Jun 4, 2020
@benjamn benjamn deleted the fix-6386-by-refining-6216 branch June 4, 2020 21:49
This was referenced Jun 4, 2020
Closed
Closed
@hwillson hwillson removed their request for review June 5, 2020 11:09
benjamn added a commit that referenced this pull request Jun 5, 2020
@benjamn
Revert #6388 and #6216, fixing #6386 and #6385.
58cad04 
This reverts commits b6da9c8 (#6388) and
c76804e (#6216).

Preventing StrictMode warnings in React is not worth introducing bugs that
break applications. We will need to reconsider how best to prevent
warnings for unmounted components.
@benjamn benjamn mentioned this pull request Jun 5, 2020
Merged
benjamn added a commit that referenced this pull request Jun 5, 2020
@benjamn
Revert #6388 and #6216, fixing #6386 and #6385. (#6395)
41fb5fe 
This reverts commits b6da9c8 (#6388) and
c76804e (#6216).

Preventing StrictMode warnings in React is not worth introducing bugs that
break applications. We will need to reconsider how best to prevent
warnings for unmounted components.
@pix2D pix2D mentioned this pull request Jun 8, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@benjamn benjamn

Labels
⚛️ React-related 📟 regression
Projects
None yet
Milestone
Release 3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@benjamn