Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some quick features we might shove into 3.5 release #8875

Merged
merged 4 commits into from
Oct 1, 2021
Merged

Some quick features we might shove into 3.5 release #8875

merged 4 commits into from
Oct 1, 2021

Conversation

brainkim
Copy link
Contributor

@brainkim brainkim commented Sep 30, 2021 •
edited
Loading

Implements #7714, #8859

@brainkim brainkim changed the base branch from main to release-3.5 September 30, 2021 18:01
@brainkim brainkim force-pushed the brian-react-quality-of-life branch from 84a81b0 to 86c6690 Compare September 30, 2021 18:06
benjamn
benjamn approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support both of these features. A couple questions below.

src/react/hooks/useLazyQuery.ts Show resolved Hide resolved
src/react/hooks/useLazyQuery.ts Outdated Show resolved Hide resolved
@brainkim brainkim force-pushed the brian-react-quality-of-life branch from 3e8fd12 to fd52e56 Compare October 1, 2021 18:48
@brainkim
Copy link
Contributor Author

brainkim commented Oct 1, 2021 •
edited
Loading

@StephenBarlow I added some initial documentation here but can split this out into a separate PR.
EDIT: I split it out into a separate PR

@brainkim brainkim force-pushed the brian-react-quality-of-life branch from fd52e56 to ddaa5df Compare October 1, 2021 18:55
brainkim added a commit that referenced this pull request Oct 1, 2021
@brainkim
Document code changes in #8875
c646ee2
@brainkim brainkim merged commit c2b0f91 into release-3.5 Oct 1, 2021
@brainkim brainkim deleted the brian-react-quality-of-life branch October 1, 2021 19:14
brainkim added a commit that referenced this pull request Oct 4, 2021
@brainkim @benjamn
Document changes in #8875 (#8878)
94cd78c 
* Document code changes in #8875

* Edits to reset function additions

* Formatting and section heading tweaks.

Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Co-authored-by: Ben Newman <ben@apollographql.com>
@hwillson hwillson mentioned this pull request Nov 12, 2021
Closed
@hwillson hwillson mentioned this pull request Nov 30, 2021
Closed
@hwillson hwillson mentioned this pull request Jan 4, 2022
Closed
@benpankow benpankow mentioned this pull request Jan 25, 2022
Closed
@camjackson
Copy link

Does this also resolve react-apollo#3499? It looks like it does?

@promet99
Copy link

promet99 commented Jul 14, 2022 •
edited
Loading

Does this also resolve react-apollo#3499? It looks like it does?

In my code, excuting useLazyquery did not return promise

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benjamn benjamn benjamn approved these changes

@StephenBarlow StephenBarlow Awaiting requested review from StephenBarlow

@hwillson hwillson Awaiting requested review from hwillson

Assignees
No one assigned
Labels
⚗️ needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brainkim @camjackson @promet99 @benjamn