Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document changes in #8875 #8878

Merged
merged 3 commits into from
Oct 4, 2021
Merged

Document changes in #8875 #8878

merged 3 commits into from
Oct 4, 2021

Conversation

brainkim
Copy link
Contributor

@brainkim brainkim commented Oct 1, 2021

No description provided.

@brainkim
Copy link
Contributor Author

brainkim commented Oct 1, 2021 •
edited
Loading

Commits are messed up, hold while I fix.

@brainkim brainkim force-pushed the brian-document-react-quality-of-life branch from dabfd57 to 05eebe5 Compare October 1, 2021 19:08
@brainkim brainkim force-pushed the brian-document-react-quality-of-life branch from 05eebe5 to c646ee2 Compare October 1, 2021 19:12
@brainkim brainkim changed the base branch from release-3.5 to main October 1, 2021 19:13
@StephenBarlow
Copy link
Contributor

@brainkim I have pushed some edits that make assumptions! Please review and make sure I did not make dreaded false assumptions 🙏

@brainkim
Copy link
Contributor Author

brainkim commented Oct 2, 2021

These assumptions do not make a something out of u and me. Good callout about the cache stuff. Thanks!

benjamn
benjamn approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple formatting tweaks, but this LGTM. Thanks for taking care of this @brainkim!

@brainkim
Copy link
Contributor Author

brainkim commented Oct 4, 2021

We should probably clarify that these are 3.5 features like for updateQuery() and updateFragment().

Also @benjamn, when do you want to merge documentation PRs? I would prefer if it lags a little compared to the actual release.

@benjamn benjamn changed the base branch from main to release-3.5 October 4, 2021 15:35
@benjamn
Copy link
Member

benjamn commented Oct 4, 2021 •
edited
Loading

Let's use the release-3.5 branch to collect docs changes like these.

@benjamn benjamn added this to the Release 3.5 milestone Oct 4, 2021
@brainkim brainkim merged commit 94cd78c into release-3.5 Oct 4, 2021
@brainkim brainkim deleted the brian-document-react-quality-of-life branch October 4, 2021 18:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benjamn benjamn benjamn approved these changes

@StephenBarlow StephenBarlow Awaiting requested review from StephenBarlow

Assignees
No one assigned
Labels
📝 documentation
Projects
None yet
Milestone
Release 3.5
Development

Successfully merging this pull request may close these issues.
3 participants
@brainkim @StephenBarlow @benjamn