refactor: Multipart parsers #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvincestari
commented
Nov 7, 2023
calvincestari
added a commit
that referenced
this pull request
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the multipart response parsers so that each can be built to focus on just their parser data specification logic and common shared logic to process the general multipart response format.
MultipartResponseParsingInterceptornow handles the mechanics of the multipart message chunk parsing.MultipartResponseSpecificationParsernow just requires each specification parser to handle the logic for parsing each data line for a single specification.This only includes error based-tests for
MultipartResponseDeferParserbecause the executor is not complete. Only once the executor is able to handle deferred fragments will the parsing based-tests be able to succeed.