Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement deferSpec response parser #3146

Closed
Tracked by #3093
calvincestari opened this issue Jul 24, 2023 · 1 comment · Fixed by apollographql/apollo-ios-dev#126
Closed
Tracked by #3093

Implement deferSpec response parser #3146

calvincestari opened this issue Jul 24, 2023 · 1 comment · Fixed by apollographql/apollo-ios-dev#126
Assignees
@calvincestari
Milestone
`@defer` support

Comments

@calvincestari
Copy link
Member

calvincestari commented Jul 24, 2023 •
edited
Loading

This is part 2 to #3118 and is an implementation of the parser for the deferSpec protocol specification.

I have a local branch with an implementation but I'm not satisfied with it and I think it should change direction as I commented on in #3118

.. I'm not happy with the way each multipart parser needs to implement errors and a full parser. I think those should be centralized and each spec parser should only be unique in the actual data format.
@calvincestari calvincestari mentioned this issue Jul 24, 2023
Merged
@calvincestari calvincestari added this to the `@defer` support milestone Jul 24, 2023
This was referenced Jul 31, 2023
Merged
Merged
@calvincestari
Copy link
Member Author

The MultipartResponseDeferParser was introduced in #3167. This work should build on that.

@calvincestari calvincestari self-assigned this Aug 6, 2023
@calvincestari calvincestari linked a pull request Nov 7, 2023 that will close this issue
refactor: Multipart parsers apollographql/apollo-ios-dev#126
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calvincestari calvincestari

Labels
None yet
Projects
None yet
Milestone
`@defer` support
Development

Successfully merging a pull request may close this issue.

refactor: Multipart parsers apollographql/apollo-ios-dev
1 participant
@calvincestari