feature: Adds request Accept header
#3167
Conversation
| @@ -70,6 +71,10 @@ public extension GraphQLOperation { | |||
| return nil | |||
| } | |||
|
|
|||
| static var hasDeferredFragments: Bool { | |||
| false | |||
There was a problem hiding this comment.
This will get set for each operation that has deferred fragments in it as part of the work for #3114.
| ) | ||
| } | ||
|
|
||
| if Operation.hasDeferredFragments { |
There was a problem hiding this comment.
Is there a chance that we will have a subscription that also has deferred fragments? This would override that protocol spec in that case.
There was a problem hiding this comment.
No, I don't think defer is supported in subscriptions. In that case we'd be indirectly relying on graphql-js to invalidate the operation.
There was a problem hiding this comment.
Is graphql-js already handling that case?
There was a problem hiding this comment.
I went looking for validation of my assumption and it was not as easy to find as I thought it was. I did find reference to not being allowed on a Subscription in the spec edits PR though.
There was a problem hiding this comment.
As long as it's definitely not allowed in the specification, I'm fine with merging this then. If there is a bug in the future, that is a bug in GraphQL-js not Apollo-iOS. :)
There was a problem hiding this comment.
I think we're fine. IMO defer on subscriptions is pointless.
There was a problem hiding this comment.
OK, more confirmation in Apollo Client's httpLink.
Closes #3143
Related to #3146 (introduces the
MultipartResponseDeferParser)This PR ensures that when an operation is recognized as having deferred fragments the request automatically has the correct
AcceptHTTP header set to specify a multipart response and one that matches the currently configured defer spec parser.