Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: multipart response parsers #3119

Merged
merged 5 commits into from
Jul 31, 2023

Conversation

calvincestari
Copy link
Member

@calvincestari calvincestari commented Jul 13, 2023

Closes #3118

  • Introduced a new protocol for multipart response parsers
  • Refactored the subscription parsing logic into MultipartResponseSubscriptionParser
  • Refactored errors for the context of where they are raised from

@calvincestari calvincestari linked an issue Jul 18, 2023 that may be closed by this pull request
Copy link
Member

@BobaFetters BobaFetters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good

@calvincestari
Copy link
Member Author

Thanks for the review @BobaFetters but I think I'm going to put this PR into draft because I'm not happy with the way each multipart parser needs to implement errors and a full parser. I think those should be centralized and each spec parser should only be unique in the actual data format.

@calvincestari calvincestari marked this pull request as draft July 24, 2023 16:09
@calvincestari calvincestari marked this pull request as ready for review July 31, 2023 19:37
@calvincestari
Copy link
Member Author

I've changed my mind and am going to merge this in because it sets up the framework for what I want to achieve. There is a note in #3146 with guidance on the desired improvement.

@calvincestari calvincestari merged commit b4a8158 into feature/defer Jul 31, 2023
@calvincestari calvincestari deleted the defer/multipart-response-parsers branch July 31, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple response parsers
2 participants