Schema type renaming #276
Merged
Schema type renaming #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
Adding new IR types to represent schema types
BobaFetters
changed the base branch from
codegen-delete-ccn
to
feature/rename-schema-types
|
Updated this draft with the initial pass at the new IR types to represent the schema types, all changes are under the |
BobaFetters
commented
Feb 23, 2024
BobaFetters
commented
Feb 23, 2024
...en/Sources/ApolloCodegenLib/Templates/RenderingHelpers/GraphQLNamedType+NameFormatting.swift
Outdated
Show resolved
Hide resolved
BobaFetters
commented
Feb 23, 2024
BobaFetters
commented
Feb 23, 2024
Redid the new name handling to be on existing GraphQL schema type objects in GraphQLCompiler instead of new IR objects.
…e-types # Conflicts: # apollo-ios-codegen/Sources/ApolloCodegenLib/Templates/InterfaceTemplate.swift
BobaFetters
commented
May 20, 2024
|
Have this updated with what should be the final implementation for handling schema type renaming after going through a few iterations. Moving on to implementing tests now and will see from there if any further tweaks are needed. |
…e-types # Conflicts: # apollo-ios-codegen/Sources/ApolloCodegenLib/Templates/RenderingHelpers/GraphQLNamedType+NameFormatting.swift # apollo-ios-codegen/Sources/GraphQLCompiler/GraphQLSchema.swift
AnthonyMDev
reviewed
May 24, 2024
apollo-ios-codegen/Sources/ApolloCodegenLib/ApolloCodegen.swift
Outdated
Show resolved
Hide resolved
AnthonyMDev
previously requested changes
Jun 5, 2024
There was a problem hiding this comment.
This is looking great! Just a few suggestions. Thanks for the work on this @BobaFetters .
Tests/ApolloCodegenTests/CodeGeneration/Templates/EnumTemplateTests.swift
Outdated
Show resolved
Hide resolved
Tests/ApolloCodegenTests/CodeGeneration/Templates/InputObjectTemplateTests.swift
Outdated
Show resolved
Hide resolved
Tests/ApolloCodegenTests/CodeGeneration/Templates/InterfaceTemplateTests.swift
Outdated
Show resolved
Hide resolved
Tests/TestCodeGenConfigurations/SchemaCustomization/Package.swift
Outdated
Show resolved
Hide resolved
Tests/TestCodeGenConfigurations/SchemaCustomization/Package.swift
Outdated
Show resolved
Hide resolved
apollo-ios-codegen/Sources/ApolloCodegenLib/Templates/InputObjectTemplate.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This is really clean. Nice job!
apollo-ios-codegen/Sources/ApolloCodegenLib/Templates/UnionTemplate.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Anthony Miller <anthonymdev@gmail.com>
AnthonyMDev
reviewed
Jun 6, 2024
...odegen/Sources/ApolloCodegenLib/Templates/RenderingHelpers/GraphQLName+RenderingHelper.swift
Outdated
Show resolved
Hide resolved
apollo-ios-codegen/Sources/ApolloCodegenLib/Templates/EnumTemplate.swift
Outdated
Show resolved
Hide resolved
…late.swift Co-authored-by: Anthony Miller <anthonymdev@gmail.com>
…gHelpers/GraphQLName+RenderingHelper.swift Co-authored-by: Anthony Miller <anthonymdev@gmail.com>
AnthonyMDev
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to customize names of schema types using the configurations options added in #242