Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Schema Type Renaming #388

Merged
merged 14 commits into from
Jun 13, 2024
Merged

Feature: Schema Type Renaming #388

merged 14 commits into from
Jun 13, 2024

Conversation

BobaFetters
Copy link
Member

This PR contains the finished schema type renaming feature that was done across multiple PRs, ready to be merged into main.

Work is from the following PRs:

Closes apollographql/apollo-ios#3283

Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for eclectic-pie-88a2ba canceled.

Name Link
🔨 Latest commit 8c4bdec
🔍 Latest deploy log https://app.netlify.com/sites/eclectic-pie-88a2ba/deploys/666a656d8e85300008ece788

Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for apollo-ios-docc canceled.

Name Link
🔨 Latest commit 8c4bdec
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docc/deploys/666a656d1e00600008a5b582

Copy link
Member

@calvincestari calvincestari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the commit list it looks like this is the three PRs we've reviewed already right? That and the merges frommain. LGTM!

@BobaFetters BobaFetters merged commit d5cbc75 into main Jun 13, 2024
26 checks passed
@BobaFetters BobaFetters deleted the feature/rename-schema-types branch June 13, 2024 16:59
BobaFetters added a commit that referenced this pull request Jun 13, 2024
BobaFetters added a commit to apollographql/apollo-ios-codegen that referenced this pull request Jun 13, 2024
BobaFetters pushed a commit that referenced this pull request Jun 13, 2024
d4eaa545 Feature: Schema Type Renaming (#388)

git-subtree-dir: apollo-ios-codegen
git-subtree-split: d4eaa5457e0b3f0f4b42671d16efe1f649003398
BobaFetters pushed a commit that referenced this pull request Jun 13, 2024
git-subtree-dir: apollo-ios-codegen
git-subtree-mainline: f05a29f
git-subtree-split: d4eaa5457e0b3f0f4b42671d16efe1f649003398
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Renaming of Generated Models for Schema Types
2 participants