Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call through to loadRecords from the MemoryCache to the SQL one #5848

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Apr 24, 2024

A followup to #5840, this calls through to the chained cache's loadRecords.

Thanks @eduardb for noticing this!

This will result in using SELECT ... WHERE IN ... instead of 1 SELECT per key. Will run benchmarks to try and see if we see perf improvements.

@BoD BoD requested a review from martinbonnin as a code owner April 24, 2024 16:37
Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 0e38695
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/662935696abaab000875c4c8

@BoD BoD merged commit 7d5c7c7 into main Apr 29, 2024
9 checks passed
@BoD BoD deleted the memory-cache-loadrecords branch April 29, 2024 09:22
BoD added a commit that referenced this pull request Apr 29, 2024
BoD added a commit that referenced this pull request Apr 29, 2024
(cherry picked from commit 7d5c7c7)
BoD added a commit to BoD/apollo-kotlin that referenced this pull request Jul 1, 2024
Adudouit added a commit to BeApp/apollo-kotlin that referenced this pull request Aug 19, 2024
…ios12-compat

* commit 'b8e8bdba951b1cb9beecabfc80433d848b2c921b': (38 commits)
  release 3.8.5
  Fix mapping of the builtin Float scalar type (apollographql#6047)
  SqlNormalizedCacheFactory make sqldriver public to support Sqlcipher data encryption. (apollographql#5972)
  Update 08-add-a-details-view.mdx for additional state handling (apollographql#5975)
  adding checks for json end_document in http batching interceptors (apollographql#5892)
  adding checks for json end_document in http transport (apollographql#5894)
  [3.x] Bump okio to 3.9.0 (apollographql#5868)
  version is now 3.8.5-SNAPSHOT
  release 3.8.4
  Backport apollographql#5848 to the v3 branch (apollographql#5863)
  Backport apollographql#5840 to the v3 branch (apollographql#5861)
  Backport apollographql#5778 to the v3 branch (apollographql#5860)
  Update min version of Kotlin in README and doc (apollographql#5750)
  version is now 3.8.4-SNAPSHOT
  release 3.8.3
  Add deprecations on symbols that are getting removed in v4 (apollographql#5746)
  docs: Correct file name discrepancies in tutorial documentation (apollographql#5740)
  Ignore IOException when calling ApolloHttpCache.remove (apollographql#5730)
  Added an implementation of a missing NSURLSessionWebSocketDelegateProtocol method in the NSURLSessionWebSocketEngine that's required in order to get a web socket to successfully reopen. (apollographql#5704)
  Update plugin-configuration.mdx (apollographql#5673)
  ...

# Conflicts:
#	gradle.properties
#	libraries/apollo-runtime/src/appleMain/kotlin/com/apollographql/apollo3/network/ws/NSURLSessionWebSocketEngine.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants