adding checks for json end_document in http batching interceptors #5892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@duzinkie: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
This was referenced May 15, 2024
|
Thanks for sending this! LGTM but we'll need your CLA in order to proceed. Can you check https://contribute.apollographql.com/? |
done, lmk if there's anything else |
… of logging a warning, as per PR feedback
Adudouit
added a commit
to BeApp/apollo-kotlin
that referenced
this pull request
Aug 19, 2024
…ios12-compat * commit 'b8e8bdba951b1cb9beecabfc80433d848b2c921b': (38 commits) release 3.8.5 Fix mapping of the builtin Float scalar type (apollographql#6047) SqlNormalizedCacheFactory make sqldriver public to support Sqlcipher data encryption. (apollographql#5972) Update 08-add-a-details-view.mdx for additional state handling (apollographql#5975) adding checks for json end_document in http batching interceptors (apollographql#5892) adding checks for json end_document in http transport (apollographql#5894) [3.x] Bump okio to 3.9.0 (apollographql#5868) version is now 3.8.5-SNAPSHOT release 3.8.4 Backport apollographql#5848 to the v3 branch (apollographql#5863) Backport apollographql#5840 to the v3 branch (apollographql#5861) Backport apollographql#5778 to the v3 branch (apollographql#5860) Update min version of Kotlin in README and doc (apollographql#5750) version is now 3.8.4-SNAPSHOT release 3.8.3 Add deprecations on symbols that are getting removed in v4 (apollographql#5746) docs: Correct file name discrepancies in tutorial documentation (apollographql#5740) Ignore IOException when calling ApolloHttpCache.remove (apollographql#5730) Added an implementation of a missing NSURLSessionWebSocketDelegateProtocol method in the NSURLSessionWebSocketEngine that's required in order to get a web socket to successfully reopen. (apollographql#5704) Update plugin-configuration.mdx (apollographql#5673) ... # Conflicts: # gradle.properties # libraries/apollo-runtime/src/appleMain/kotlin/com/apollographql/apollo3/network/ws/NSURLSessionWebSocketEngine.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the issue is discussed in: #5885
this is the recommended fix for the http batching scenario.