adding checks for json end_document in http batching interceptors #5893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@duzinkie: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for apollo-android-docs pending review.Visit the deploys page to approve it
|
martinbonnin
approved these changes
Jun 14, 2024
martinbonnin
approved these changes
Jun 14, 2024
… of logging a warning, as per PR feedback
martinbonnin
force-pushed
the
duzinkie/cronet-google-lifecycle-fix-batching-4.x
branch
from
e580a38
to
9185be6
Compare
BoD
pushed a commit
to BoD/apollo-kotlin
that referenced
this pull request
Jul 1, 2024
…ollographql#5893) * adding checks for json end_document in http batching interceptors * making not correctly ending json responses throw an exception instead of logging a warning, as per PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a cherry-pick of #5892 on the main branch.