-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Request Pipeline #1795
New Request Pipeline #1795
Commits on Sep 27, 2018
-
Revert "Make it more clear that
generateClientInfo
is an experiment……al API." This reverts commit 6d6c9ff.
Configuration menu - View commit details
-
Copy full SHA for 03a894d - Browse repository at this point
Copy the full SHA 03a894dView commit details -
Revert "Provide ability to specify client info in traces (#1631)"
This reverts commit 96af44e.
Configuration menu - View commit details
-
Copy full SHA for 68c82e6 - Browse repository at this point
Copy the full SHA 68c82e6View commit details -
Revert "Pass the context request and response extension methods (#1547)"
This reverts commit 408198e.
Configuration menu - View commit details
-
Copy full SHA for 2b470e1 - Browse repository at this point
Copy the full SHA 2b470e1View commit details -
Revert "Allow an optional function to resolve the rootValue (#1555)"
This reverts commit 4175f1b.
Configuration menu - View commit details
-
Copy full SHA for 38e7b6a - Browse repository at this point
Copy the full SHA 38e7b6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a09d514 - Browse repository at this point
Copy the full SHA a09d514View commit details -
Configuration menu - View commit details
-
Copy full SHA for 358b348 - Browse repository at this point
Copy the full SHA 358b348View commit details -
Configuration menu - View commit details
-
Copy full SHA for faf1494 - Browse repository at this point
Copy the full SHA faf1494View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4924832 - Browse repository at this point
Copy the full SHA 4924832View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fbf35c - Browse repository at this point
Copy the full SHA 7fbf35cView commit details -
Allow an optional function to resolve the rootValue (#1555)
* Allow an optional function to resolve the rootValue Passes the parsed DocumentNode AST to determine the root value, useful when providing a different rootValue for query vs mutation * Add API docs for rootValue
Configuration menu - View commit details
-
Copy full SHA for 261994c - Browse repository at this point
Copy the full SHA 261994cView commit details -
Provide ability to specify client info in traces (#1631)
* Provide ability to specify client info in traces Adds the createClientInfo to apollo-engine-reporting, which enables the differentiation of clients based on the request, operation, and variables. This could be extended to include the response. However for the first release. It doesn't quite make sense. * Use extensions and context in createClientInfo * Remove support for clientAddress The frontend will not support it in the near future * create -> generate and make default generator createClientInfo -> generateClientInfo * Clarify default values
Configuration menu - View commit details
-
Copy full SHA for 81c4642 - Browse repository at this point
Copy the full SHA 81c4642View commit details -
Make it more clear that
generateClientInfo
is an experimental API.The `generateClientInfo` API, used to set client identification attributes within traces, is an experimental API and is subject to removal or change in a future (major) Apollo Server release. Ref: #1631
Configuration menu - View commit details
-
Copy full SHA for b90ccc2 - Browse repository at this point
Copy the full SHA b90ccc2View commit details
Commits on Sep 28, 2018
-
Configuration menu - View commit details
-
Copy full SHA for e2a22b2 - Browse repository at this point
Copy the full SHA e2a22b2View commit details
Commits on Oct 2, 2018
-
Remove
posttest
npm script frompackage.json
to avoid linting on ……tests. The linting will happen in CircleCI. Additionally, we already have post-commit hooks so doing linting on every test run seems to just be generally slowing down development since any linting problems are automatically fixed when I do a commit.
Configuration menu - View commit details
-
Copy full SHA for 7c2fa2d - Browse repository at this point
Copy the full SHA 7c2fa2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ba0066e - Browse repository at this point
Copy the full SHA ba0066eView commit details -
Fix context and rootValue types in GraphQLServerOptions
The ability to pass in functions or promises shouldn't affect the type variable.
Configuration menu - View commit details
-
Copy full SHA for 7493077 - Browse repository at this point
Copy the full SHA 7493077View commit details
Commits on Oct 4, 2018
-
Import specifically
createHash
, rather than* as crypto
from `cry……pto`. This silences the deprecation messages which have been showing up in recent local development on the new request pipeline work. e.g.: > ``` > [DEP0010] DeprecationWarning: crypto.createCredentials is deprecated. > Use tls.createSecureContext instead. > [DEP0011] DeprecationWarning: > crypto.Credentials is deprecated. Use tls.SecureContext instead. > ```
Configuration menu - View commit details
-
Copy full SHA for f1bc734 - Browse repository at this point
Copy the full SHA f1bc734View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98d4fc3 - Browse repository at this point
Copy the full SHA 98d4fc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94a146a - Browse repository at this point
Copy the full SHA 94a146aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ec383d - Browse repository at this point
Copy the full SHA 1ec383dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2479473 - Browse repository at this point
Copy the full SHA 2479473View commit details
Commits on Oct 5, 2018
-
Refactor runHttpQuery and extract cache policy computation into Cache…
…ControlExtension
Configuration menu - View commit details
-
Copy full SHA for 891d629 - Browse repository at this point
Copy the full SHA 891d629View commit details -
Fix typing of context property in GraphQLServerOptions
The actual resolving of the context happens in ApolloServer#graphQLServerOptions, but errors thrown while doing that are currently converted to a throwing function.
Configuration menu - View commit details
-
Copy full SHA for d80209e - Browse repository at this point
Copy the full SHA d80209eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 07a9493 - Browse repository at this point
Copy the full SHA 07a9493View commit details -
Import specifically
createHash
, rather than* as crypto
from `cry……pto`. This silences the deprecation messages which have been showing up in recent local development on the new request pipeline work. e.g.: > ``` > [DEP0010] DeprecationWarning: crypto.createCredentials is deprecated. > Use tls.createSecureContext instead. > [DEP0011] DeprecationWarning: > crypto.Credentials is deprecated. Use tls.SecureContext instead. > ```
Configuration menu - View commit details
-
Copy full SHA for 68f50cd - Browse repository at this point
Copy the full SHA 68f50cdView commit details -
Fix cacheControl property in Config and GraphQLServerOptions
While cacheControl can take a boolean when passing it in to ApolloServer as part of a Config, these will be converted to default options before passing them on as options.
Configuration menu - View commit details
-
Copy full SHA for 8746358 - Browse repository at this point
Copy the full SHA 8746358View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ea8240 - Browse repository at this point
Copy the full SHA 6ea8240View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7d7b0b - Browse repository at this point
Copy the full SHA d7d7b0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for aeabb86 - Browse repository at this point
Copy the full SHA aeabb86View commit details -
Configuration menu - View commit details
-
Copy full SHA for f051c7c - Browse repository at this point
Copy the full SHA f051c7cView commit details
Commits on Oct 6, 2018
-
Merge remote-tracking branch 'origin/typescript-project-references' i…
…nto abernix/re-new-request-pipeline
Configuration menu - View commit details
-
Copy full SHA for 282ea7e - Browse repository at this point
Copy the full SHA 282ea7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 482a320 - Browse repository at this point
Copy the full SHA 482a320View commit details -
Simplify plugin API and fix circular dependency issues
We compile `requestPipelineAPI.ts` as a separate TypeScript project to avoid circular dependency issues from the `apollo-server-plugin-base` package depending on the types in `apollo-server-core`.
Configuration menu - View commit details
-
Copy full SHA for e928adf - Browse repository at this point
Copy the full SHA e928adfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 231c7f1 - Browse repository at this point
Copy the full SHA 231c7f1View commit details -
Fix failing tests by passing in structured engine apiKey
Since activating the EngineReportingAgent is now dependent on being able to extract an engineServiceId from the API key, tests need to specify one that follows the expected structure.
Configuration menu - View commit details
-
Copy full SHA for f4d3a37 - Browse repository at this point
Copy the full SHA f4d3a37View commit details
Commits on Oct 7, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 5281f3f - Browse repository at this point
Copy the full SHA 5281f3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 10e12e8 - Browse repository at this point
Copy the full SHA 10e12e8View commit details
Commits on Oct 8, 2018
-
Configuration menu - View commit details
-
Copy full SHA for ba61960 - Browse repository at this point
Copy the full SHA ba61960View commit details -
Configuration menu - View commit details
-
Copy full SHA for c28e3e2 - Browse repository at this point
Copy the full SHA c28e3e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f11914a - Browse repository at this point
Copy the full SHA f11914aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a12673a - Browse repository at this point
Copy the full SHA a12673aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3e46ca - Browse repository at this point
Copy the full SHA f3e46caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 00e9838 - Browse repository at this point
Copy the full SHA 00e9838View commit details -
Configuration menu - View commit details
-
Copy full SHA for 428430c - Browse repository at this point
Copy the full SHA 428430cView commit details
Commits on Oct 9, 2018
-
Configuration menu - View commit details
-
Copy full SHA for b571541 - Browse repository at this point
Copy the full SHA b571541View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7c9a6d - Browse repository at this point
Copy the full SHA b7c9a6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 02b645b - Browse repository at this point
Copy the full SHA 02b645bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4234ca - Browse repository at this point
Copy the full SHA f4234caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 960810c - Browse repository at this point
Copy the full SHA 960810cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b1760d - Browse repository at this point
Copy the full SHA 5b1760dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e40f4a2 - Browse repository at this point
Copy the full SHA e40f4a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59bc1c9 - Browse repository at this point
Copy the full SHA 59bc1c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f6594a - Browse repository at this point
Copy the full SHA 0f6594aView commit details
Commits on Oct 10, 2018
-
Configuration menu - View commit details
-
Copy full SHA for cea6404 - Browse repository at this point
Copy the full SHA cea6404View commit details -
Configuration menu - View commit details
-
Copy full SHA for f942af7 - Browse repository at this point
Copy the full SHA f942af7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fab039 - Browse repository at this point
Copy the full SHA 3fab039View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4863f6 - Browse repository at this point
Copy the full SHA b4863f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4400ac - Browse repository at this point
Copy the full SHA f4400acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 17ed84d - Browse repository at this point
Copy the full SHA 17ed84dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4d672c - Browse repository at this point
Copy the full SHA e4d672cView commit details -
Pass the context request and response extension methods (#1547)
* Pass the context along to all the extension methods Addresses #1343 With this change you should now be able to implement an extension like so: ```javascript class MyErrorTrackingExtension extends GraphQLExtension { willSendResponse(o) { const { context, graphqlResponse } = o context.trackErrors(graphqlResponse.errors) return o } } ``` Edit by @evans : fixes #1343 fixes #614 as the request object can be taken from context or from requestDidStart fixes #631 "" * Remove context from extra extension functions The context shouldn't be necessary for format, parse, validation, and execute. Format generally outputs the state of the extension. Parse and validate don't depend on the context. Execution includes the context argument as contextValue * Move change entry under vNext
Configuration menu - View commit details
-
Copy full SHA for 84bc834 - Browse repository at this point
Copy the full SHA 84bc834View commit details -
Follow-up un-reverted work to maintain support in the new request pip…
…eline. Prior to embarking on the request pipeline work, and to facilitate development on the new request pipeline, @martijnwalraven and myself intentionally reverted some commits that had been recently introduced but conflicted with the request pipeline branch that was already in-flight. Rather than dealing with an incredibly difficult merge conflict, it was easier to revert them an re-apply them later. Original commits, reversions, and reintroductions: * 6d6c9ff, 03a894d, b90ccc2 * 96af44e, 68c82e6, 81c4642 * 408198e, 2b470e1, 84bc834 * 4175f1b, 38e7b6a, 261994c As is demonstrated by this short follow-up commit, this was all that was necessary to make it work in the new model - once that model was finished. While we're certain that the new request pipeline and its plugin model will actually better support some of the behavior that required these initial commits in the name of not introducing breaking changes, we feel it's necessary to maintain their support. I will point out, if you are at all affected by the above commits, we may consider deprecating portions of those APIs in the not too distant future, but we hope that the new model will help support those needs even better.
Configuration menu - View commit details
-
Copy full SHA for 9089cc5 - Browse repository at this point
Copy the full SHA 9089cc5View commit details